After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685914 - messageTray: Do not add the tray unconditionally to ctrl-alt-tab
messageTray: Do not add the tray unconditionally to ctrl-alt-tab
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.6.1
Depends on:
Blocks:
 
 
Reported: 2012-10-10 20:50 UTC by Florian Müllner
Modified: 2012-10-11 06:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
messageTray: Do not add the tray unconditionally to ctrl-alt-tab (2.21 KB, patch)
2012-10-10 20:50 UTC, Florian Müllner
accepted-commit_now Details | Review
messageTray: Do not add the tray unconditionally to ctrl-alt-tab (2.21 KB, patch)
2012-10-10 21:23 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2012-10-10 20:50:51 UTC
See patch.
Comment 1 Florian Müllner 2012-10-10 20:50:55 UTC
Created attachment 226206 [details] [review]
messageTray: Do not add the tray unconditionally to ctrl-alt-tab

Commit 448517032e5de87 added the message tray unconditionally to
the Ctrl-Alt-Tab popup, but while this makes sense for a normal
session, we do not want it in the login screen.
Be a bit more careful where we make the tray available.
Comment 2 Florian Müllner 2012-10-10 20:52:12 UTC
We should include this in 3.6.1.
Comment 3 drago01 2012-10-10 21:12:05 UTC
Review of attachment 226206 [details] [review]:

Looks good.
Comment 4 Florian Müllner 2012-10-10 21:23:42 UTC
Created attachment 226210 [details] [review]
messageTray: Do not add the tray unconditionally to ctrl-alt-tab

Woops, actually no - the original version didn't work properly, this one should work as expected ...
Comment 5 Matthias Clasen 2012-10-11 03:04:44 UTC
+1 from me
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-10-11 03:18:06 UTC
Review of attachment 226210 [details] [review]:

::: js/ui/messageTray.js
@@ +1503,3 @@
             }));
 
+        Main.sessionMode.connect('updated', Lang.bind(this, this._sessionModeUpdated));

This is usually spelt "_sessionUpdated"

@@ +1523,3 @@
+
+    _sessionModeUpdated: function() {
+        if (Main.sessionMode.isLocked || Main.sessionMode.isGreeter)

I don't believe Ctrl+Alt+Tab works in the lock screen, given that it's a modal keybinding and everything.
Comment 7 Florian Müllner 2012-10-11 06:01:30 UTC
Attachment 226210 [details] pushed as d2e830c - messageTray: Do not add the tray unconditionally to ctrl-alt-tab