After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685855 - shield: better lock screen placement with keynav
shield: better lock screen placement with keynav
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-10 03:16 UTC by Matthias Clasen
Modified: 2012-10-15 20:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ScreenShield: show the unlock dialog on the primary monitor when using the keyboard (3.26 KB, patch)
2012-10-14 16:47 UTC, Giovanni Campagna 		none Details | Review
ScreenShield: show the unlock dialog on the primary monitor when using the keyboard (3.81 KB, patch)
2012-10-14 20:07 UTC, Giovanni Campagna 		needs-work Details | Review
ScreenShield: show the unlock dialog on the primary monitor when using the keyboard (4.38 KB, patch)
2012-10-15 18:02 UTC, Giovanni Campagna 		committed Details | Review

Description Matthias Clasen 2012-10-10 03:16:29 UTC 
If raising the curtain with the keyboard (esc/return), the login screen is displayed on the monitor where the mouse pointer is. It should show login on the primary monitor in this situation. 

(See https://live.gnome.org/Boston2012/Multimonitor )
Comment 1 Giovanni Campagna 2012-10-14 16:47:00 UTC 
Created attachment 226417 [details] [review]
ScreenShield: show the unlock dialog on the primary monitor when using the keyboard

Make ModalDialog.open() accept an optional monitor index argument, and
pass the primary index when the dialog is activated using ESC or Return.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-10-14 17:02:51 UTC 
Review of attachment 226417 [details] [review]:

This means that if we unplug a monitor while in the unlock dialog, it won't jump to the new primary monitor. You already introduced a "primary" property for the constraint; why not use that?
Comment 3 Giovanni Campagna 2012-10-14 20:07:42 UTC 
Created attachment 226423 [details] [review]
ScreenShield: show the unlock dialog on the primary monitor when using the keyboard

Make ModalDialog.open() accept an optional "onPrimary" argument, and
make it true when the dialog is activated using ESC or Return.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-14 20:34:44 UTC 
Review of attachment 226423 [details] [review]:

::: js/ui/modalDialog.js
@@ +207,3 @@
+            this._monitorConstraint.primary = true;
+        else
+            this._monitorConstraint.index = global.screen.get_current_monitor();

You need to make MonitorConstraint turn primary off when setting an index, then.
Comment 5 Giovanni Campagna 2012-10-15 18:02:20 UTC 
Created attachment 226498 [details] [review]
ScreenShield: show the unlock dialog on the primary monitor when using the keyboard

Make ModalDialog.open() accept an optional onPrimary argument, and
pass it when the dialog is activated using ESC or Return.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-10-15 20:31:54 UTC 
Review of attachment 226498 [details] [review]:

I'd prefer the layout parts to be a separate patch, but OK.
Comment 7 Giovanni Campagna 2012-10-15 20:45:53 UTC 
Attachment 226498 [details] pushed as 48fb16b - ScreenShield: show the unlock dialog on the primary monitor when using the keyboard