After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685852 - login screen: distribution logo badly placed
login screen: distribution logo badly placed
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-10 03:03 UTC by Matthias Clasen
Modified: 2012-10-25 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdm: Move logo into the panel (7.20 KB, patch)
2012-10-17 16:59 UTC, Florian Müllner 		none Details | Review
Screenshot using cropped fedora logo (315.19 KB, image/png)
2012-10-19 12:48 UTC, Florian Müllner 		  Details
symbolic fedora logo (7.10 KB, image/svg+xml)
2012-10-25 09:34 UTC, Allan Day 		  Details
gdm: Move logo into the panel (6.91 KB, patch)
2012-10-25 15:14 UTC, Florian Müllner 		committed Details | Review
Screenshot using Allan's logo (327.78 KB, image/png)
2012-10-25 15:16 UTC, Florian Müllner 		  Details

Description Matthias Clasen 2012-10-10 03:03:30 UTC 
The distribution logo is displayed in the middle above the list. This visually clashes with the layout of the rest of the login screen. It would be better to place the logo in the top-left hand corner of the screen, in the top bar. 

(See https://live.gnome.org/Boston2012/Multimonitor )
Comment 1 Florian Müllner 2012-10-17 16:59:40 UTC 
Created attachment 226660 [details] [review]
gdm: Move logo into the panel

GDM has a 'logo' key in its schema to allow distributors to add
some branding. It is currently placed above the user list, which
no longer works too well since the login screen lost its dialog
window. Display the logo in the top-left corner instead of the
Activities button instead.
Comment 2 Matthias Clasen 2012-10-18 21:49:29 UTC 
do you have a screenshot ?
Comment 3 Florian Müllner 2012-10-18 22:30:39 UTC 
No, I can get one tomorrow. It looks like crap though, as the current logo is clearly not meant to be displayed at 16x16 pixels.
Comment 4 Florian Müllner 2012-10-19 12:48:02 UTC 
Created attachment 226820 [details]
Screenshot using cropped fedora logo
Comment 5 Allan Day 2012-10-25 09:34:44 UTC 
Created attachment 227236 [details]
symbolic fedora logo

Hmm, we probably need a symbolic logo that includes the name. Not sure if the attached is perfect, but it should work for testing.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-10-25 12:13:00 UTC 
That violates trademark guidelines.
Comment 7 Allan Day 2012-10-25 13:21:28 UTC 
(In reply to comment #6)
> That violates trademark guidelines.

Well it would be up to Fedora to provide their own icon. This is just for testing (and we can provide guidelines on what type of icon to provide for this).
Comment 8 Florian Müllner 2012-10-25 13:37:32 UTC 
(In reply to comment #7)
> This is just for testing

And it's appreciated! I'll update the patch to work with non-square logos ...
Comment 9 Florian Müllner 2012-10-25 15:14:50 UTC 
Created attachment 227274 [details] [review]
gdm: Move logo into the panel

Update patch to allow non-square logos
Comment 10 Florian Müllner 2012-10-25 15:16:09 UTC 
Created attachment 227275 [details]
Screenshot using Allan's logo
Comment 11 Jasper St. Pierre (not reading bugmail) 2012-10-25 15:45:59 UTC 
Review of attachment 227274 [details] [review]:

Sure.

::: js/gdm/loginDialog.js
@@ +92,3 @@
+
+        this._settings = new Gio.Settings({ schema: GdmUtil.LOGIN_SCREEN_SCHEMA });
+        this._settings.connect('changed::' + GdmUtil.LOGO_KEY,

As I said before, I really want to stop this concatenation silliness.
Comment 12 Florian Müllner 2012-10-25 17:05:13 UTC 
Attachment 227274 [details] pushed as 9efe528 - gdm: Move logo into the panel