After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685809 - Add Bluespec SystemVerilog syntax highlighter
Add Bluespec SystemVerilog syntax highlighter
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-09 14:09 UTC by Philip Withnall
Modified: 2012-10-12 10:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add Bluespec SystemVerilog language specification (8.43 KB, patch)
2012-10-11 09:01 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2012-10-09 14:09:02 UTC
BlueSpec SystemVerilog is a high-level hardware description language.

http://www.bluespec.com/SmallExamples/index.html
Comment 1 Philip Withnall 2012-10-11 09:01:27 UTC
Created attachment 226237 [details] [review]
Add Bluespec SystemVerilog language specification

Here we go. This works for the basic BSV files I’ve been using, but may be missing keywords for more advanced BSV files.
Comment 2 Ignacio Casal Quinteiro (nacho) 2012-10-11 09:03:59 UTC
Review of attachment 226237 [details] [review]:

It looks good to me. Just reindent with 2 spaces and fix the 2 minor issues.

::: data/language-specs/bluespec.lang
@@ +17,3 @@
+ You should have received a copy of the GNU Lesser General Public
+ License along with this library; if not, write to the Free Software
+ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA	02110-1301	USA

there is something wrong here, some tabs instead of spaces?

@@ +29,3 @@
+
+	<styles>
+		<style id="system-task" _name="System Task" map-to="def:keyword"/>

align this a bit
Comment 3 Philip Withnall 2012-10-12 09:32:00 UTC
Comment on attachment 226237 [details] [review]
Add Bluespec SystemVerilog language specification

Committed to master with the whitespace/indentation fixes.

commit 8c0bf1bbf6ee13407218243ffd0392be1cb55869
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Thu Oct 11 09:59:38 2012 +0100

    Bug 685809 — Add Bluespec SystemVerilog syntax highlighter
    
    Add a syntax highlighter for Bluespec SystemVerilog. This includes some
    improvements to the standard Verilog highlighter to highlight printf-style
    format specifiers in strings.
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=685809

 data/language-specs/Makefile.am   |   1 +
 data/language-specs/bluespec.lang | 188 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 data/language-specs/verilog.lang  |  12 +++++++++
 3 files changed, 201 insertions(+)
Comment 4 Paolo Borelli 2012-10-12 10:00:18 UTC
You missed to add the new file to POTFILES.in

Actually we did not branch yet so we cannot add new strings... But we can just go ahead and branch. Would you mind creating the gnome-3-6 branch starting from the previous commit?
Comment 5 Philip Withnall 2012-10-12 10:49:46 UTC
(In reply to comment #4)
> You missed to add the new file to POTFILES.in

Oh bother. Fixed:

commit 7e1b29b03efd3ab3c26ad4a176dc7c38850debb0
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Fri Oct 12 11:48:57 2012 +0100

    i18n: Add bluespec.lang to POTFILES.in
    
    See: https://bugzilla.gnome.org/show_bug.cgi?id=685809

 po/POTFILES.in | 1 +
 1 file changed, 1 insertion(+)

> Actually we did not branch yet so we cannot add new strings... But we can just
> go ahead and branch. Would you mind creating the gnome-3-6 branch starting from
> the previous commit?

Done.