After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685772 - prefer-plain generates endless part list with broken multipart/alternative
prefer-plain generates endless part list with broken multipart/alternative
Status: RESOLVED DUPLICATE of bug 686278
Product: evolution
Classification: Applications
Component: Mailer
3.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[formatter]
Depends on:
Blocks:
 
 
Reported: 2012-10-08 23:29 UTC by Dan Vrátil
Modified: 2013-09-13 01:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Simple test-case (664 bytes, text/plain)
2012-10-08 23:29 UTC, Dan Vrátil 		  Details
Patch (1.42 KB, patch)
2012-10-09 00:09 UTC, Dan Vrátil 		none Details | Review

Description Dan Vrátil 2012-10-08 23:29:32 UTC 
Created attachment 226087 [details]
Simple test-case

Broken multipart/alternative emails where text/html subpart is BEFORE text/plain cause prefer-plain module to create an "endless" EMailPartList.
Comment 1 Dan Vrátil 2012-10-09 00:09:07 UTC 
Created attachment 226088 [details] [review]
Patch

This patch fixes the concatenation of parts GSLists so that it should handle any possible order of subparts within multipart/alternative.

This patch does not solve the fact, that such broken emails result in the mail parts being displayed in wrong order (the test case above will display the HTML attachment first, then the plain text part *). The question is whether we want to further complicate the code because of a few broken generated mails (I'm not aware of any MUAs doing this)...


*) with "Show suppressed HTML parts as attachments" enabled and prefer-plain set to "Prefer plain text" or "Only ever show plain text".
Comment 2 Dan Vrátil 2012-10-17 10:16:17 UTC 
Milan made a better patch.

*** This bug has been marked as a duplicate of bug 686278 ***