After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685755 - Remove deprecated widgets in opensubtitles plugins.
Remove deprecated widgets in opensubtitles plugins.
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Subtitle Downloader plugin
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-10-08 21:16 UTC by Maël Lavault
Modified: 2012-10-09 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove deprecated widgets (6.71 KB, patch)
2012-10-08 21:16 UTC, Maël Lavault 		needs-work Details | Review

Description Maël Lavault 2012-10-08 21:16:35 UTC 
Created attachment 226077 [details] [review]
Remove deprecated widgets

Hi,

Here is a patch which removes deprecated widgets in opensubtitle plugin.

The last version of glade also made some automatic cleanups to the .ui file.
Comment 1 Philip Withnall 2012-10-09 07:51:53 UTC 
Review of attachment 226077 [details] [review]:

Looks good to me. Please commit to master. Thanks!
Comment 2 Bastien Nocera 2012-10-09 15:54:35 UTC 
Comment on attachment 226077 [details] [review]
Remove deprecated widgets

Too much churn for me actually (I did the same thing but with 12 lines changed).
Comment 3 Bastien Nocera 2012-10-09 15:54:55 UTC 
commit 370189533262733fd0fe4010a9b1b0e3e616c662
Author: Maël Lavault <mael.lavault@mailz.org>
Date:   Tue Oct 9 17:52:23 2012 +0200

    opensubtitles: Remove use of deprecated widgets
    
    https://bugzilla.gnome.org/show_bug.cgi?id=685755
Comment 4 Maël Lavault 2012-10-09 16:06:32 UTC 
Yep i know we could do this in less line, but since every new release of glade will make these change (reordering the code a bit, this is intended to be better parsed by future glade version see : https://bugzilla.gnome.org/show_bug.cgi?id=643666 , in particular comment 4) why not integrate them in the code ?

Anyway, thanks for committing !