After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685616 - user-accounts: Remove the realmd version check
user-accounts: Remove the realmd version check
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-06 16:20 UTC by Stef Walter
Modified: 2012-10-15 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
user-accounts: Remove the realmd version check (3.41 KB, patch)
2012-10-06 16:21 UTC, Stef Walter 		none Details | Review
user-accounts: Remove the realmd version check (3.70 KB, patch)
2012-10-06 16:43 UTC, Stef Walter 		reviewed Details | Review
user-accounts: Remove the realmd version check (9.14 KB, patch)
2012-10-13 18:49 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-10-06 16:20:16 UTC 
No need to do the version check anymore.
Comment 1 Stef Walter 2012-10-06 16:21:32 UTC 
Created attachment 225939 [details] [review]
user-accounts: Remove the realmd version check

The idea is that the realmd DBus API will remain stable
from now on, so remove the version check. It was broken anyway.
Comment 2 Stef Walter 2012-10-06 16:43:21 UTC 
Created attachment 225941 [details] [review]
user-accounts: Remove the realmd version check

The idea is that the realmd DBus API will remain stable
from now on, so remove the version check. It was broken anyway.
Comment 3 Matthias Clasen 2012-10-09 03:10:20 UTC 
Review of attachment 225941 [details] [review]:

Looks good to me.
Comment 4 Bastien Nocera 2012-10-09 06:26:39 UTC 
Review of attachment 225941 [details] [review]:

You need to switch to an async call now that you don't need to check the version straight away.

::: panels/user-accounts/um-realm-manager.c
@@ -235,3 @@
-        /*
-         * TODO: Remove this version checking. This is temporary code, so
-         * just use sync here. Shortly we'll be stabilizing the realmd

You don't need to be sync here anymore though.
Comment 5 Stef Walter 2012-10-09 14:27:34 UTC 
(In reply to comment #4)
> Review of attachment 225941 [details] [review]:
> 
> You need to switch to an async call now that you don't need to check the
> version straight away.
> 
> ::: panels/user-accounts/um-realm-manager.c
> @@ -235,3 @@
> -        /*
> -         * TODO: Remove this version checking. This is temporary code, so
> -         * just use sync here. Shortly we'll be stabilizing the realmd
> 
> You don't need to be sync here anymore though.

AFAIK, by using G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES um_realm_provider_proxy_new_sync() will not block.
Comment 6 David Zeuthen (not reading bugmail) 2012-10-09 15:32:23 UTC 
(In reply to comment #5)
> AFAIK, by using G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES
> um_realm_provider_proxy_new_sync() will not block.

This is only true if the proxy is for a unique name (e.g. ":1.42") and not a well-known name (e.g. "net.company.Foo"). So in your case (by looking at the patch), it's not true....
Comment 7 Stef Walter 2012-10-13 18:49:40 UTC 
Created attachment 226387 [details] [review]
user-accounts: Remove the realmd version check

Now instantiating the provider asynchronously.
Comment 8 Bastien Nocera 2012-10-15 09:24:15 UTC 
Review of attachment 226387 [details] [review]:

Looks fine to me.
Comment 9 Stef Walter 2012-10-15 09:43:05 UTC 
Attachment 226387 [details] pushed as 60e9ee0 - user-accounts: Remove the realmd version check