After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685581 - Connecting never seems to emiit notify::state when ACTIVED
Connecting never seems to emiit notify::state when ACTIVED
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: API
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
: 685634 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-05 20:10 UTC by drago01
Modified: 2012-10-07 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core: fix NMDevice::state-changed emission of ACTIVATED (bgo #685581) (1.35 KB, patch)
2012-10-05 20:45 UTC, Dan Winship
accepted-commit_now Details | Review

Description drago01 2012-10-05 20:10:50 UTC
After updating to NetworkManager-0.9.7.0-2.git20121004.fc18.x86_64 the network icon in gnome-shell never switches from "connecting" to connected.

While debugging (using log()) prints I noticed that ._notifyActivated which is setup like this:

 a._notifyStateId = a.connect('notify::state', Lang.bind(this, this._notifyActivated));

Is never called with state == NetworkManager.ActiveConnectionState.ACTIVATED even though the connection comes up just fine (and nmcli reports that the connection is connected).
Comment 1 David Zeuthen (not reading bugmail) 2012-10-05 20:12:29 UTC
I'm also seeing this bug. Same NM version.
Comment 2 Dan Winship 2012-10-05 20:45:34 UTC
Created attachment 225900 [details] [review]
core: fix NMDevice::state-changed emission of ACTIVATED (bgo #685581)

NMPolicy was calling nm_device_state_changed() from inside its
NMDevice::state-changed handler, which caused the D-Bus signal to get
lost. Use nm_device_queue_state() instead.
Comment 3 Dan Williams 2012-10-05 21:15:15 UTC
Review of attachment 225900 [details] [review]:

Patch looks good.
Comment 4 Dan Winship 2012-10-07 11:42:05 UTC
*** Bug 685634 has been marked as a duplicate of this bug. ***