After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685562 - suspend using power button doesn't lock the screen
suspend using power button doesn't lock the screen
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-05 13:40 UTC by bingquick
Modified: 2012-10-24 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add lock_screensaver function to do_config_power_action in plugins/media-keys/gsd-media-keys-manager.c (5.00 KB, patch)
2012-10-05 13:40 UTC, bingquick 		none Details | Review

Description bingquick 2012-10-05 13:40:45 UTC 
Created attachment 225882 [details] [review]
add lock_screensaver function to do_config_power_action in plugins/media-keys/gsd-media-keys-manager.c

When power button configured as suspend key and use it to suspend the machine, it doesn't lock the screen as screen lid does, the attached patch just simply ported the  lock_screensaver() function from plugins/power/gsd-power-manager.c to plugins/media-keys/gsd-media-keys-manager.c to add the lock screen function. 

May be it's better to move the lock_screensaver() function to common/gsd-power-helper.c?
Comment 1 Matthias Clasen 2012-10-05 13:43:09 UTC 
That is not the right way to fix this, imo.

Instead, gnome-shell should take a delay lock itself and lock the screen when it detects a coming suspend. That would also eliminate the guessing games we play about how long the shield animation might take.
Comment 2 Bastien Nocera 2012-10-08 09:36:44 UTC 
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 681969 ***
Comment 3 Bastien Nocera 2012-10-22 11:43:07 UTC 
See bug 686482
Comment 4 bingquick 2012-10-24 14:53:18 UTC 
I can confirm the gnome-settings-daemon-3.7.1 update fixes my problem. Thanks guys.