After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685490 - audioencoder: don't require base class to implement to start vfunc
audioencoder: don't require base class to implement to start vfunc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.x
Other Linux
: Normal normal
: 1.0.1
Assigned To: Andoni Morales
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-04 12:12 UTC by Andoni Morales
Modified: 2012-10-04 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audioencoder: don't require base class to implement to start vfunc (1.07 KB, patch)
2012-10-04 12:12 UTC, Andoni Morales 		committed Details | Review
audioencoder: don't require the base class to implement to stop vfunc (1019 bytes, patch)
2012-10-04 12:37 UTC, Andoni Morales 		reviewed Details | Review

Description Andoni Morales 2012-10-04 12:12:03 UTC 
Created attachment 225799 [details] [review]
audioencoder:  don't require base class to implement to start vfunc

The start vfunc is documented as optional.
Comment 1 Tim-Philipp Müller 2012-10-04 12:19:03 UTC 
Thanks, pushed:

commit 795d366a0cb97285ab6cceef04a3acf995c1f3da
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Thu Oct 4 14:05:13 2012 +0200

    audioencoder: don't fail if the start vfunc is not implemented
    
    Fix behaviour to match documentation and decoder class behaviour.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=685490
Comment 2 Andoni Morales 2012-10-04 12:37:16 UTC 
Created attachment 225801 [details] [review]
audioencoder:  don't require the base class to implement to stop vfunc

And the same for the stop vfunc :)
Comment 3 Tim-Philipp Müller 2012-10-04 12:43:33 UTC 
Thanks, but I fixed this differently now (and before I saw your patch - I said on IRC I'd fix it):

 commit cdb22274e634644e3d42303e6c09042cc940a9c1
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Thu Oct 4 13:40:32 2012 +0100

    audioencoder: make stop() vfunc also optional
    
    Just change default value, since we also don't want to fail
    if we want to deactivate and aren't active or want to activate
    and are already active.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=685490