After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685471 - don't use generic var names, unbreak build on OpenBSD
don't use generic var names, unbreak build on OpenBSD
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
3.6.x (obsolete)
Other OpenBSD
: Normal major
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-10-04 07:02 UTC by Antoine Jacoutot
Modified: 2012-10-04 14:26 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Attachments
prefix generic var names with "ev_" (1.65 KB, patch)
2012-10-04 07:02 UTC, Antoine Jacoutot 		none Details | Review

Description Antoine Jacoutot 2012-10-04 07:02:38 UTC 
Created attachment 225773 [details] [review]
prefix generic var names with "ev_"

Hi.

OpenBSD (and maybe other OS) already declare stdout and stdin in <stdio.h>
which breaks evolution build, so prefix both with "_ev" to prevent clashing to prevent:
e-mail-formatter-text-highlight.c:190: error: expected identifier or '(' before '&' token

Would that be alright to push?
Thank you.
Comment 1 Matthew Barnes 2012-10-04 13:21:11 UTC 
I would prefer more descriptive names like "pipe_stdin" and "pipe_stdout", but otherwise it's fine to push.  Thanks for catching this.
Comment 2 Antoine Jacoutot 2012-10-04 13:57:20 UTC 
Thank you Matthew.
It's in as 1cfe0327ca436a687383412664e3a5c2869c7dda (with the "pipe_stdin" and "pipe_stdout" modification).
Comment 3 Matthew Barnes 2012-10-04 14:26:11 UTC 
Thanks.  I cherry-picked it to the gnome-3-6 branch:

http://git.gnome.org/browse/evolution/commit/?h=gnome-3-6&id=ceda9fa5e742b511886335078cce6f5d2667295f