GNOME Bugzilla – Bug 685436
Allow using a raw JS object as an item in a list/model store
Last modified: 2013-05-07 17:22:24 UTC
That makes this work: let model = new Gtk.ListStore(); model.set_column_types([GObject.TYPE_POINTER]); ['cat', 'dog', 'coyote', 'pizza'].forEach(function(animal) { let iter = model.append(); model.set(iter, [0], [{animal: animal}]); }); The implementation is a bit ugly. PyGObject has this feature too, but I didn't look to see how it worked. Maybe some form of typechecking would help?
Created attachment 225711 [details] [review] gtype: Don't recurse infinitely while getting a GType If we pass a plain old JS object to gjs_gtype_get_actual_gtype, it will recurse infinitely, getting the constructor. Any object's constructor is a Function, and unfortunately Function.prototype.constructor returns itself. Fix this by only recursing once.
Created attachment 225712 [details] [review] value: Allow marshalling a raw JSObject into a GValue This allows us to use raw JSObjects inside things like tree/list stores, instead of having to create a pesky GObject beforehand.
This is another request from Mathematical Coffee, by the way.
Review of attachment 225712 [details] [review]: Sorry but no. The JS object will be collected and will become a dangling pointer. Python can have this, because they use reference counting and a cycle collector, not a mark and sweep GC. JS can't, and there is nothing we can do about it, as rooting the object will very likely create an uncollectable cycle.
The first patch still makes sense though.
Review of attachment 225711 [details] [review]: Indeed this patch makes sense, sorry it went unnoticed this long.
Attachment 225711 [details] pushed as df28a9c - gtype: Don't recurse infinitely while getting a GType