GNOME Bugzilla – Bug 685388
Confused shell syntax in omf.make
Last modified: 2012-10-03 17:55:15 UTC
While investigating this failure in a test rebuild of Ubuntu, I tracked it down to a bug in gnome-common: https://launchpadlibrarian.net/117450436/buildlog_ubuntu-quantal-i386.gbonds_2.0.3-2.1_FAILEDTOBUILD.txt.gz make[4]: Entering directory `/build/buildd/gbonds-2.0.3/help/C' for file in gbonds-C.omf; do \ absfile=./$file \ test -r $file && absfile=$file \ scrollkeeper-preinstall /usr/share/gnome/help/gbonds/C/gbonds.xml $absfile $file.out; \ done; \ touch omf_timestamp ERROR: Cannot parse gbonds-C.omf.out. Is it valid? make[4]: Leaving directory `/build/buildd/gbonds-2.0.3/help/C' ... make[6]: Entering directory `/build/buildd/gbonds-2.0.3/help/C' /bin/bash ../../mkinstalldirs /build/buildd/gbonds-2.0.3/debian/tmp/usr/share/omf/gbonds mkdir -p -- /build/buildd/gbonds-2.0.3/debian/tmp/usr/share/omf/gbonds for file in gbonds-C.omf; do \ absfile=./$file.out; \ test -r $file.out && absfile=$file.out; \ /usr/bin/install -c -m 644 $absfile /build/buildd/gbonds-2.0.3/debian/tmp/usr/share/omf/gbonds/$file; \ done /usr/bin/install: cannot stat `./gbonds-C.omf.out': No such file or directory make[6]: *** [install-data-hook-omf] Error 1 make[6]: Leaving directory `/build/buildd/gbonds-2.0.3/help/C' The problem comes down to two missing semicolons in the omf_timestamp rule, causing its commands to be parsed completely wrongly such that $absfile is empty at the point when the shell expands the scrollkeeper-preinstall command. I've verified that the attached trivial patch fixes this.
Created attachment 225684 [details] [review] Add missing semicolons to omf_timestamp rule
This bug was introduced in commit 1b2fb3fb47405908eb53d0db46329a64a1697a59 while fixing bug 315320.
Comment on attachment 225684 [details] [review] Add missing semicolons to omf_timestamp rule Pushed to master as commit ee12b92340223bb33b9da232132c44cacecc7968, thanks.