After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685368 - Dash - launchers should slide when rearranging
Dash - launchers should slide when rearranging
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-03 09:29 UTC by Allan Day
Modified: 2021-07-05 14:21 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6


Attachments
Slide launchers when rearranging dash. (3.38 KB, patch)
2012-11-01 16:32 UTC, Stefano Candori
none Details | Review
patch (5.00 KB, patch)
2014-02-27 13:27 UTC, Chris Johns (ter0)
needs-work Details | Review

Description Allan Day 2012-10-03 09:29:56 UTC
If I drag a launcher over the dash the launchers slide out of the way to create a gap. Subsequently dragging the app over the dash causes the launchers to rearrange, but they move in a jerky manner. The launchers should smoothly slide when rearranging.
Comment 1 Stefano Candori 2012-10-31 17:46:37 UTC
I'm working on a patch for this bug.
Comment 2 Stefano Candori 2012-11-01 16:32:17 UTC
Created attachment 227820 [details] [review]
Slide launchers when rearranging dash.

When the user grabs and rearrange a launcher on the dash the other launchers
slide out nicely, creating a space for the place holder. Still need some work.
Comment 3 Stefano Candori 2012-11-01 16:35:48 UTC
It works fine, but i think the general behaviour could be improved. Sometimes the launchers "dance" a little too much on the dash.
Comment 4 Allan Day 2012-11-01 17:00:40 UTC
Thanks for working on this, Stefano!

I've just done a quick test... this is definitely better but does feel a bit too sensitive like you said. Probably needs a little timeout or something. Looking forward to the next iteration!
Comment 5 Stefano Candori 2012-11-01 17:01:48 UTC
Thanks Allan. Yep, i was thinking to a little timeout too. I'll let you know asap.
Comment 6 Chris Johns (ter0) 2014-02-27 13:27:32 UTC
Created attachment 270469 [details] [review]
patch

I fixed the original patch and added a short timeout (100ms). It does feel quite slow to me, the animations seem to take a bit too long.
Comment 7 Carlos Soriano 2014-03-12 10:35:57 UTC
Comment on attachment 227820 [details] [review]
Slide launchers when rearranging dash.

I guess this is obsolete
Comment 8 Carlos Soriano 2014-03-12 13:20:42 UTC
Review of attachment 270469 [details] [review]:

I see one problem.
You are waiting to animate place holders one by one,
so the animation feels sluggish.
The solution would be to animate each place holder independently.
The problem with current approach is that, each time you animate,
a new item is added to the list, which can increase the list height
a lot if you re moving fast trough the dash.
Using clutter implicit animations solve that problem (I made a patch with it),
but we are trying to not let in implicit clutter animations, so we don't have
clutter animations and tweener twisted around the code.

At the end, I didn't find a good/easy solution for this using explicit animations
with tweener.

::: js/ui/dash.js
@@ +904,3 @@
+                this._launcherDragTimeoutId = Mainloop.timeout_add(DASH_LAUNCHER_DRAG_TIMEOUT,
+                    Lang.bind(this, function() {
+                        let newPos = pos >= oldPos ? pos + 1 : pos;

Problem here is that sometimes is incosistent because of the old place holder counting as a item in the list.
Comment 9 GNOME Infrastructure Team 2021-07-05 14:21:17 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of  gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/

Thank you for your understanding and your help.