GNOME Bugzilla – Bug 685356
Adjust egrep(1) usage to be more portable
Last modified: 2019-02-22 03:17:07 UTC
Created attachment 225666 [details] [review] Adjust egrep(1) usage to be more portable The egrep(1) usage in the configure script of eog-plugins currently the check_plugin_defined() function to always return 1. The attached patch makes the egrep(1) invocation a lot more portable across grep implementations (e.g. BSD). Would it be OK to push this patch?
Review of attachment 225666 [details] [review]: Well, I am not sure I'd call the misusage "stupid", rather an oversight. ::: configure.ac.orig @@ +176,2 @@ check_plugin_defined() { + if echo "$2" | egrep "$1" > /dev/null; That's not exactly the same. As it would accept partial matches as well (e.g. a plugin called "epostr" would match when searching for "postr"). How about grep -w "$1"? Would that work on BSD?
Fair enough, that was quite a stupid oversight on my behalf ;-) using grep -w "$1" works fine here; can I push that change?
(In reply to comment #2) > Fair enough, that was quite a stupid oversight on my behalf ;-) > > using grep -w "$1" works fine here; can I push that change? Very well then, feel free to push. Thanks for noticing. :)
Thanks.