After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685355 - gnome-shell-build-setup.sh: Move default directory to ~/gnome
gnome-shell-build-setup.sh: Move default directory to ~/gnome
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-03 04:26 UTC by Owen Taylor
Modified: 2012-10-05 17:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-shell-build-setup.sh: Move default directory to ~/gnome (2.34 KB, patch)
2012-10-03 04:26 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2012-10-03 04:26:18 UTC
gnome-shell-build-setup.sh is generally useful for working on GNOME.
If moving on from hacking on gnome-shell to some other module,
having the checkout location be ~/gnome-shell is a little odd and
cumbersome, so start out checking things out into ~/gnome/source
and installing them into ~/gnome/install.

Add a warning if the old ~/gnome-shell exists to avoid unnecessary
checking out of every module again.
Comment 1 Owen Taylor 2012-10-03 04:26:20 UTC
Created attachment 225657 [details] [review]
gnome-shell-build-setup.sh: Move default directory to ~/gnome
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-10-03 04:32:14 UTC
Review of attachment 225657 [details] [review]:

Considering we put jhbuild (and now git-bz) in a directory called ~/Source, I wonder if it makes sense to have ~/Source/gnome.
Comment 3 Owen Taylor 2012-10-03 15:03:34 UTC
Ah, you are looking to have GNOME Shell sources under the excellent path:

 ~/Source/gnome/source/gnome-shell/src

:-) ... I agree that the ~/Source vs. ~/gnome/source split seems a bit extraneous and confusing. The reasoning behind it, as much as I can recover it at this point is to allow the user, if they want, to just delete ~/gnome then restart without messing up their command line. It also separates out jhbuild-managed modules from one that aren't managed by jhbuild.

I think - for now - I want to keep that split, because I don't have an alternative that I like better. The most appealing alternative to me would be to move jhbuild and git-bz into ~/gnome/source - simpler, but does confuse jhbuild and non-jhbuild mangaged modules, and leaves the user with broken links in ~/bin if they remove ~/gnome.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-03 15:58:02 UTC
(In reply to comment #3)
> Ah, you are looking to have GNOME Shell sources under the excellent path:
> 
>  ~/Source/gnome/source/gnome-shell/src

Well, it's not ~/Source/gnome-shell/source/gnome-shell/src anymore...

Also, that's what I do.

I wonder if ~/Source/gnome and ~/.jhbuild-checkout/gnome might be better. I haven't really ever had to trek inside my checkout dir since I discovered jhbuild shell.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-10-04 06:58:51 UTC
Review of attachment 225657 [details] [review]:

Either way, this is probably a good idea.

::: tools/build/gnome-shell-build-setup.sh
@@ +306,3 @@
+
+  To avoid starting again from scratch you should remove the empty directory
+  and move your old '$HOME/gnome-shell' to '$HOME/gnome':

This advice won't work, given that jhbuild (or libtool or autoconf or something) uses absolute paths all over the place. I ended up in build hell after I did this.
Comment 6 Owen Taylor 2012-10-05 17:33:39 UTC
(In reply to comment #5)
> Review of attachment 225657 [details] [review]:
> 
> Either way, this is probably a good idea.

I went ahead with the original idea of just moving ~/gnome since I wanted to get something done on this for the Boston Summit newcomers tutorial this evening and I hadn't decided on anything better :-)
 
> ::: tools/build/gnome-shell-build-setup.sh
> @@ +306,3 @@
> +
> +  To avoid starting again from scratch you should remove the empty directory
> +  and move your old '$HOME/gnome-shell' to '$HOME/gnome':
> 
> This advice won't work, given that jhbuild (or libtool or autoconf or
> something) uses absolute paths all over the place. I ended up in build hell
> after I did this.

I think it will work if you remove ~/gnome/install - that will cause everything to be rebuilt, no .la files reused, and everything to be reconfigured. I'll add that to the warning.
Comment 7 Owen Taylor 2012-10-05 17:34:39 UTC
Attachment 225657 [details] pushed as b99bb3d - gnome-shell-build-setup.sh: Move default directory to ~/gnome