GNOME Bugzilla – Bug 685352
gnome-shell-build-setup.sh: Add additional system packages
Last modified: 2015-02-27 17:40:13 UTC
Add system packages for asn1Parser, cracklib, ruby, wireless-tools
Created attachment 225654 [details] [review] gnome-shell-build-setup.sh: Add additional system packages
Review of attachment 225654 [details] [review]: ::: tools/build/gnome-shell-build-setup.sh @@ +72,3 @@ pkgconfig: f:pkgconfig python: f:python +ruby: fds:ruby # WebKit Sigh. Can we eliminate WebKit? @@ +117,3 @@ uuid: f:libuuid-devel d:uuid-dev # Networkmanager vorbis: f:libvorbis-devel d:libvorbis-dev # libcanberra +wireless-tools: f:wireless-tools-devel d:libiw-dev s:libiw-devel # NetworkManager NetworkManager needs to be built? Don't we have system packages for this?
(In reply to comment #2) > Review of attachment 225654 [details] [review]: > > ::: tools/build/gnome-shell-build-setup.sh > @@ +72,3 @@ > pkgconfig: f:pkgconfig > python: f:python > +ruby: fds:ruby # WebKit > > Sigh. Can we eliminate WebKit? The fact that WebKit individually takes as long or longer to build then all other modules combined is certainly a problem. The jhbuild modulesets have no way of representing that we could do with any-old system WebKitGTK as long as we aren't building epiphany, but if we build epiphany we need a much more specific version. The modules in core that require WebKitGTK are: *gnome-online-accounts, empathy, epiphany, sushi, yelp, *libproxy, seed With the *'ed ones being the ones that are built when you are just building gnome-shell. > @@ +117,3 @@ > uuid: f:libuuid-devel d:uuid-dev # Networkmanager > vorbis: f:libvorbis-devel d:libvorbis-dev # libcanberra > +wireless-tools: f:wireless-tools-devel d:libiw-dev s:libiw-devel # > NetworkManager > > NetworkManager needs to be built? Don't we have system packages for this? jhbuild will never use system packages for a module that is being built from Git.
(In reply to comment #3) > The fact that WebKit individually takes as long or longer to build then all > other modules combined is certainly a problem. The jhbuild modulesets have no > way of representing that we could do with any-old system WebKitGTK as long as > we aren't building epiphany, but if we build epiphany we need a much more > specific version. Can we specify skip['WebKit'] = True in the jhbuildrc by default, even as a hack to get people up and running quickly?
Comment on attachment 225654 [details] [review] gnome-shell-build-setup.sh: Add additional system packages $:andre\> patch --no-backup-if-mismatch -p1 < patch patching file tools/build/gnome-shell-build-setup.sh Reversed (or previously applied) patch detected! Assume -R? [n] y Hunk #3 FAILED at 94. 1 out of 4 hunks FAILED -- saving rejects to file tools/build/gnome-shell-build-setup.sh.rej Hence setting 'needs-rework' as patch does not apply cleanly.
I don't know quite how outdated the build-setup.sh script is by now, but it has been updated more recently than this bug ...