Bug 685316 - getting default schemas value doesn't work in GNOME 3.6
getting default schemas value doesn't work in GNOME 3.6
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: gsettings backend
0.13.x
Other Linux
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2012-10-02 17:32 UTC by Sebastien Bacher
Modified: 2012-10-02 18:16 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
engine/: drop DConfChangesetList (4.29 KB, patch)
2012-10-02 17:34 UTC, Allison Lortie (desrt) (extended vacation) 		committed Details | Diff | Review
gsettings/: support correct read of default values (1.53 KB, patch)
2012-10-02 17:34 UTC, Allison Lortie (desrt) (extended vacation) 		none Details | Diff | Review
gsettings/: support correct read of default values (1.53 KB, patch)
2012-10-02 17:48 UTC, Allison Lortie (desrt) (extended vacation) 		committed Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Sebastien Bacher 2012-10-02 17:32:36 UTC 
Doing "g_settings_delay() g_settings_reset() g_settings_get_string()" used to return the default schemas value of a key, it doesn't in GNOME 3.6
Comment 1 Allison Lortie (desrt) (extended vacation) 2012-10-02 17:34:02 UTC 
Created attachment 225604 [details] [review]
engine/: drop DConfChangesetList

It's really just a GQueue...
Comment 2 Allison Lortie (desrt) (extended vacation) 2012-10-02 17:34:04 UTC 
Created attachment 225605 [details] [review]
gsettings/: support correct read of default values

The existing code had a /* XXX */ for properly dealing with the case of
the user requesting the default value.  We should probably implement
this...
Comment 3 Allison Lortie (desrt) (extended vacation) 2012-10-02 17:48:50 UTC 
Created attachment 225607 [details] [review]
gsettings/: support correct read of default values

The existing code had a /* XXX */ for properly dealing with the case of
the user requesting the default value.  We should probably implement
this...


I forgot that GQueue is both stack and heap allocated.... I allocated it
on the stack but then used the heap function to clean it up...
Comment 4 Allison Lortie (desrt) (extended vacation) 2012-10-02 18:16:16 UTC 
Attachment 225604 [details] pushed as b5f59c9 - engine/: drop DConfChangesetList
Attachment 225607 [details] pushed as 3f6a05f - gsettings/: support correct read of default values
Note You need to log in before you can comment on or make changes to this bug.