After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685286 - Shortcuts assigned to the Menu key do not work
Shortcuts assigned to the Menu key do not work
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: keyboard
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
: 660566 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-02 13:50 UTC by Yotam Benshalom
Modified: 2012-11-08 18:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keygrab: Allow grabbing Menu unmodified by default (1023 bytes, patch)
2012-10-02 15:46 UTC, Rui Matos
committed Details | Review

Description Yotam Benshalom 2012-10-02 13:50:21 UTC
The Menu key (next to the right control) can be set in the UI as a trigger to change keyboard layouts, but it no longer works as it did in 3.5. When pressed, the Menu key only pops the right-click menu. The shortcut command is not activated.
Comment 1 Rui Matos 2012-10-02 14:03:24 UTC
I don't think unmodified Menu ever worked for any of the system settings' shortcuts.

If you mean that you'd like Menu to work for switching keyboard layouts then I can add it to the modifiers only setting (which is separate and not configurable from System Settings but from gnome-tweak-tool instead).
Comment 2 Yotam Benshalom 2012-10-02 15:01:39 UTC
Thank you, Rui, that would be better than nothing. Menu did work for changing keyboard layouts (maybe not for other tasks).
Comment 3 Bastien Nocera 2012-10-02 15:08:05 UTC
I don't think there's anything stopping the Menu button from working for anything in the media keys plugin. It's not a modifier, and it should work.
Comment 4 Rui Matos 2012-10-02 15:46:40 UTC
Created attachment 225596 [details] [review]
keygrab: Allow grabbing Menu unmodified by default

--

(In reply to comment #3)
> I don't think there's anything stopping the Menu button from working for
> anything in the media keys plugin. It's not a modifier, and it should work.

You're right that it's not a modifier but still the grabbing code
prevents unmodified regular keys except for a few cases. We can add
the Menu key also as an exception though.
Comment 5 Bastien Nocera 2012-10-02 15:52:30 UTC
Review of attachment 225596 [details] [review]:

++
Comment 6 Rui Matos 2012-10-02 16:05:15 UTC
Attachment 225596 [details] pushed as 2184aa5 - keygrab: Allow grabbing Menu unmodified by default

Yotam, this means that Menu should work now from the system setting's
regular shortcuts UI.
Comment 7 Yotam Benshalom 2012-10-02 16:43:38 UTC
Thank you for this extremely quick fix! I will check it when it hits my gnome-settings & ibus ppa.

An unrelated question: are you aware of the keyboard grabbing issue in LibreOffice, which stopped recognising common shortcuts (Ctrl+X etc.) in non-Latin layouts? Other apps (gtk, mozilla) behave fine. Should I post a new bug, or is there already one I missed?
Comment 8 Rui Matos 2012-10-03 16:26:14 UTC
(In reply to comment #7)
> An unrelated question: are you aware of the keyboard grabbing issue in
> LibreOffice, which stopped recognising common shortcuts (Ctrl+X etc.) in
> non-Latin layouts? Other apps (gtk, mozilla) behave fine. Should I post a new
> bug, or is there already one I missed?

Sounds like a bug in LibreOffice: https://bugs.freedesktop.org/show_bug.cgi?id=55585 .
Comment 9 Yotam Benshalom 2012-10-03 16:29:16 UTC
Thanks, it might be related. But LibreOffice shortcuts worked fine up until I upgraded gnome-settings to 3.6.
Comment 10 Yotam Benshalom 2012-10-03 16:30:13 UTC
Oh, I read the comments in that bug now - yes, this is the culprit :)
Comment 11 Bastien Nocera 2012-10-11 06:58:06 UTC
*** Bug 660566 has been marked as a duplicate of this bug. ***