After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685278 - Live search is pretty slow when groups are enabled
Live search is pretty slow when groups are enabled
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-02 12:18 UTC by Guillaume Desmottes
Modified: 2012-10-02 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
roster-view: add some delay before actually starting the live search (2.30 KB, patch)
2012-10-02 13:05 UTC, Guillaume Desmottes
none Details | Review
roster-view: add some delay before actually starting the live search (2.40 KB, patch)
2012-10-02 13:12 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2012-10-02 12:18:49 UTC
Live searching in the roster can takes a while when groups are enabled. Without groups it's pretty fast so there is probably so optimization to do there.
Comment 1 Guillaume Desmottes 2012-10-02 13:05:50 UTC
Created attachment 225584 [details] [review]
roster-view: add some delay before actually starting the live search

This avoid stacking a bunch of useless searches while user is typing as we
can't stop the old search before starting the new one.
Comment 2 Guillaume Desmottes 2012-10-02 13:06:55 UTC
We could do more optimisations (I'll feel bugs about this) but this simple patch already improved things a lot and is safe enough for 3.6.
Comment 3 Guillaume Desmottes 2012-10-02 13:12:22 UTC
Created attachment 225585 [details] [review]
roster-view: add some delay before actually starting the live search

This avoid stacking a bunch of useless searches while user is typing as we
can't stop the old search before starting the new one.
Comment 4 Guillaume Desmottes 2012-10-02 13:15:29 UTC
Attachment 225585 [details] pushed as 35c4220 - roster-view: add some delay before actually starting the live search
Comment 5 Guillaume Desmottes 2012-10-02 13:22:25 UTC
See also bug #685281