After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685274 - Use GRL_METADATA_KEY_INVALID instead of NULL with grl_metadata_key_list_new()
Use GRL_METADATA_KEY_INVALID instead of NULL with grl_metadata_key_list_new()
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-02 10:40 UTC by Murray Cumming
Modified: 2012-10-07 00:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-Use-GRL_METADATA_KEY_INVALID-instead-of-NULL.patch (3.20 KB, patch)
2012-10-02 10:40 UTC, Murray Cumming
committed Details | Review

Description Murray Cumming 2012-10-02 10:40:18 UTC
Created attachment 225571 [details] [review]
0001-Use-GRL_METADATA_KEY_INVALID-instead-of-NULL.patch

This is what the grl_metadata_key_list_new() documentation says we should do. NULL is the same thing, but that is an internal detail. The patch fixes this, including, most importantly, the examples.
Comment 1 Juan A. Suarez Romero 2012-10-07 00:43:37 UTC
commit a6baa038b4ab344f3c9768f251d6865197ddd9b9
Author: Murray Cumming <murrayc@openismus.com>
Date:   Tue Oct 2 12:35:16 2012 +0200

    Use GRL_METADATA_KEY_INVALID instead of NULL.
    
    This is what the grl_metadata_key_list_new() documentation
    says we should do. NULL is the same thing, but that is an internal
    detail.
    
    This fixes https://bugzilla.gnome.org/show_bug.cgi?id=685274
    
    Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>

 doc/grilo/plugins-sources.xml            | 2 +-
 examples/browsing.c                      | 2 +-
 examples/efficient-metadata-resolution.c | 4 ++--
 examples/multivalues.c                   | 2 +-
 examples/searching.c                     | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)