After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685271 - [PATCH] audiocd: Add support for musicbrainz5
[PATCH] audiocd: Add support for musicbrainz5
Status: RESOLVED DUPLICATE of bug 677286
Product: rhythmbox
Classification: Other
Component: general
2.97
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-02 10:12 UTC by Paul Menzel
Modified: 2012-10-02 10:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] audiocd: Add support for musicbrainz5 (25.71 KB, patch)
2012-10-02 10:15 UTC, Paul Menzel
none Details | Review

Description Paul Menzel 2012-10-02 10:12:26 UTC
Please apply the patch carried in the Debian packages to add support for MusicBrainz5 [1][2].

The patch is from Robert Ancell and is against v2.97 and unfortunately does not apply cleanly to v2.98.

Unfortunately although Jon mentions it is from upstream [1] I neither could find a bug report in the GNOME BTS nor a commit in the Git repository. So I guess Jon means Ubuntu. But that is just a guess.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677247#24
[2] http://anonscm.debian.org/viewvc/pkg-gnome/packages/unstable/rhythmbox/debian/patches/rb-mb5.patch?view=log
Comment 1 Jonathan Matthew 2012-10-02 10:15:13 UTC
Rhythmbox doesn't use libmusicbrainz any more.
Comment 2 Paul Menzel 2012-10-02 10:15:46 UTC
Created attachment 225568 [details] [review]
[PATCH] audiocd: Add support for musicbrainz5

Patch by Robert Ancell.
Comment 3 Paul Menzel 2012-10-02 10:17:30 UTC
(In reply to comment #1)
> Rhythmbox doesn't use libmusicbrainz any more.

Oh, I am sorry.

commit 19528b5a05f0f89c04b060130133f6242fb24bbb
Author: Jonathan Matthew <jonathan@d14n.org>
Date:   Mon Sep 3 21:24:04 2012 +1000

    audiocd: replace sj-metadata code
    
    Rather than using libmusicbrainz, we now read disc information
    using GStreamer and talk to the musicbrainz web service using
    libsoup.
    
    We now use a combo box in the info bar rather than a separate dialog
    for choosing between multiple album matches.
Comment 4 Paul Menzel 2012-10-02 10:43:01 UTC
I am so sorry for the noise.

1. I overlooked the forwarded address in the Debian report [1].
2. For not finding the existing closed bug 677286 [2] in the GNOME BTS. Although I blame Bugzilla for that, since I searched for »product:"rhythmbox" musicbr« and that bug was not under the results.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677247#24
[2] https://bugzilla.gnome.org/show_bug.cgi?id=677286

*** This bug has been marked as a duplicate of bug 677286 ***