GNOME Bugzilla – Bug 685252
Fixes for "recently scanned locations"
Last modified: 2012-10-03 17:01:28 UTC
see patches
Created attachment 225539 [details] [review] Sort recent info by MRU Otherwise they show up in creation order
Created attachment 225540 [details] [review] Make sure to update recent info when scanning a location
Created attachment 225541 [details] [review] Move a scanned location to the end of the list To match the recency order
Created attachment 225543 [details] [review] Move a scanned location to the end of the list To match the recency order
Created attachment 225591 [details] [review] Move a scanned location to the end of the list To match the recency order
Review of attachment 225539 [details] [review]: looks good
Review of attachment 225591 [details] [review]: I am not convinced about this one, I think we should keep the location list as stable as possible
Review of attachment 225540 [details] [review]: ::: src/baobab-window.vala @@ -251,2 +251,3 @@ void on_scan_location_activate (Location location) { set_active_location (location); + location_list.add_location (location); this was not needed because I did not want to change the order in a running instance... I guess you add it to make sure the MRU timestamp is updated, right? In that case it make sense to me, but at that point let's move it in set_active_location so that we avoid the duplicated line in the two callers.
Created attachment 225669 [details] [review] Make sure to update recent info when scanning a location
Review of attachment 225669 [details] [review]: looks good
Attachment 225539 [details] pushed as 6b1d976 - Sort recent info by MRU Attachment 225669 [details] pushed as 4fc1e61 - Make sure to update recent info when scanning a location