After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685238 - Plural forms
Plural forms
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-10-01 18:21 UTC by Marek Černocký
Modified: 2013-01-24 18:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
l10n: Remove the internal copy of glib from the list of gettext files (1.18 KB, patch)
2012-11-23 15:12 UTC, Neil Roberts
none Details | Review

Description Marek Černocký 2012-10-01 18:21:01 UTC
Message

Could not allocate %lu bytes to read file "%s"
(deps/glib/gfileutils.c, deps/glib/gfileutils.c)

requires to use ngettext instead gettext due "byte" plural forms.


https://live.gnome.org/TranslationProject/DevGuidelines/Plurals
Comment 1 Neil Roberts 2012-11-23 15:05:04 UTC
This string comes from an internal copy of glib. The internal copy is only used if Cogl is configured with --disable-glib. That means it effectively won't be used in a Gnome system. It is only likely to be used on a limited embedded system and I wonder if in that case it doesn't really make sense to translate the strings anyway. Maybe we should just remove the internal copy of glib from the list of translated files?

The string has been fixed in glib itself via bug 687698
Comment 2 Neil Roberts 2012-11-23 15:12:56 UTC
Created attachment 229728 [details] [review]
l10n: Remove the internal copy of glib from the list of gettext files

We probably don't want to include the internal copy of glib in the
list of files to scan for translatable strings because these strings
already exist in glib itself and it is a waste of translator's time to
translate them again.

If we wanted to make this work properly, maybe we could adopt a system
where we also copy the translated strings from glib into cogl and then
merge them into the message catalog during the build. However it
doesn't seem like translated strings would be that useful in
situations where --disable-glib is used, so maybe it's not worth
bothering with.
Comment 3 Robert Bragg 2013-01-22 20:17:16 UTC
this looks good to land to me
Comment 4 Neil Roberts 2013-01-22 23:42:32 UTC
Ok, I've pushed it to master. I have a feeling there is some sort of automatic process that it will add it back again, but I don't know how it works. It was originally added in this commit:

http://git.gnome.org/browse/cogl/commit/?id=aa5f8e9b9396
Comment 5 Piotr Drąg 2013-01-24 17:41:50 UTC
I'm very much non-automatic process. :)

I added it to POTFILES.in in order to make intltool happy, but from what I see above I should've put it in POTFILES.skip instead. Now I have pushed a commit to master and cogl-1.14 fixing this. Sorry for the mess I made!

http://git.gnome.org/browse/cogl/commit/?id=bdf88473149e7b7d10bd955e109557ed0231c791
Comment 6 Neil Roberts 2013-01-24 18:01:00 UTC
Oh, that makes more sense. Thank you!