After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685166 - Style the registration form
Style the registration form
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-09-30 21:07 UTC by Gil Forcada
Modified: 2012-10-04 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix registration page (5.18 KB, patch)
2012-10-02 11:59 UTC, Tom Tryfonidis
reviewed Details | Review

Description Gil Forcada 2012-09-30 21:07:38 UTC
We do have a really beautiful website (http://l10n.gnome.org) but the registration forms [1] are completely misplaced. They should be fixed and styled properly.

[1] http://l10n.gnome.org/register/
Comment 1 Tom Tryfonidis 2012-10-02 11:59:26 UTC
Created attachment 225578 [details] [review]
Fix registration page

Here is a patch :)
Screenshot: https://www.dropbox.com/s/py9mp521lzzi070/register_page.png
Comment 2 Gil Forcada 2012-10-02 23:02:49 UTC
Review of attachment 225578 [details] [review]:

::: common/static/css/text.css
@@ +76,3 @@
 
+.main_register {
+    font-size: 13pt;

Shouldn't we use pixels instead of points? To keep consistency?
Comment 3 Gil Forcada 2012-10-02 23:03:42 UTC
Apart from that (in comment 2) I would say that it can hit git at any time!

Great work!
Comment 4 Tom Tryfonidis 2012-10-03 13:10:24 UTC
I pushed it to master but i can't the changes to the website.
I've also used pixels instead of points.

http://git.gnome.org/browse/damned-lies/commit/?id=5ce78a04d63af4deeac869b61ae7cb92db8f3ca1
Comment 5 Tom Tryfonidis 2012-10-03 14:39:22 UTC
Gil, it would also be nice to style the login page. 

Two minor fixes:
Adding one new string e.g. "User Login" or an existing one "Log in",
Styling the text under the above string with .main_register class.

Screenshot: https://www.dropbox.com/s/z0qse0odo7ypx67/login_page.png

What do you think ?
Comment 6 Gil Forcada 2012-10-03 20:56:34 UTC
Looks great, please commit.

In the meantime I will update the website with the registration fixes.

Thanks a lot!!
Comment 7 Tom Tryfonidis 2012-10-03 21:13:27 UTC
You're welcome Gil.

Make sure to update the site with the login fixes.

http://git.gnome.org/browse/damned-lies/commit/?id=0ca932055ecaa8e7158f462e3d8079ebab0e043f
Comment 8 Gil Forcada 2012-10-04 21:35:57 UTC
l10n.gnome.org is updated ;)

Great work!