After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685127 - do not hardcode -lgcov
do not hardcode -lgcov
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.6.x (obsolete)
Other OpenBSD
: Normal major
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-09-30 09:10 UTC by Antoine Jacoutot
Modified: 2012-09-30 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use $(CODE_COVERAGE_LDFLAGS) instead of hardcoding -lgcov (851 bytes, patch)
2012-09-30 09:11 UTC, Antoine Jacoutot 		accepted-commit_now Details | Review

Description Antoine Jacoutot 2012-09-30 09:10:50 UTC 
Hi.

OpenBSD does not have libgcov. While there is a proper check for it, it's still hardcoded in tests/libedata-cal/Makefile.am.
This patch takes care care of it for me.

Would that be alright to push?
Thank you.
Comment 1 Antoine Jacoutot 2012-09-30 09:11:41 UTC 
Created attachment 225412 [details] [review]
use $(CODE_COVERAGE_LDFLAGS) instead of hardcoding -lgcov
Comment 2 Matthew Barnes 2012-09-30 12:01:43 UTC 
Thanks for catching that.

Go ahead and push to master, and then "git cherry-pick -x" the commit to the gnome-3-6 branch if you wouldn't mind.
Comment 3 Antoine Jacoutot 2012-09-30 15:04:20 UTC 
Thank you Matthew; both master and gnome-3-6 have been updated.