GNOME Bugzilla – Bug 685121
error: previous declaration of 'reboot'
Last modified: 2012-09-30 16:55:53 UTC
Created attachment 225408 [details] [review] prefix generic names with gs_ Hi. Some gboolean have too generic names which makes the build fails on OpenBSD. e.g. gnome-session-quit.c:48: error: 'reboot' redeclared as different kind of symbol /usr/include/unistd.h:480: error: previous declaration of 'reboot' was here The attached patch proposes to prefix all the logout, reboot... with 'gs_'. Would something like this be alright to push? Thank you.
Review of attachment 225408 [details] [review]: I prefer prefixing all options with "opt_".
Created attachment 225431 [details] [review] prefix generic names with opt_ Sure thing. Is that what you were expecting?
Review of attachment 225431 [details] [review]: Looks nicer, yes. Please do add a link to this bug in the commit message, per https://live.gnome.org/GnomeLove/SubmittingPatches
All done. Thank you Colin.