After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685082 - fix memory leak about length arg and type info (_pygi_argument_to_array)
fix memory leak about length arg and type info (_pygi_argument_to_array)
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
Git master
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-28 23:33 UTC by Alban Browaeys
Modified: 2012-10-04 07:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
length arg and type info memory leak (1.24 KB, patch)
2012-09-28 23:33 UTC, Alban Browaeys 		needs-work Details | Review

Description Alban Browaeys 2012-09-28 23:33:15 UTC 
Created attachment 225361 [details] [review]
length arg and type info memory leak

Attach patch fix the memory leak about length_arg_info and length_type_info in _pygi_argument_to_array.
Comment 1 Simon Feltman 2012-09-29 02:40:52 UTC 
Review of attachment 225361 [details] [review]:

Hi Alban,

Thanks for the patch. I recommend we switch this part of the code to use stack allocation along with g_callable_info_load_arg and g_arg_info_load_type. Then we won't have to deal with unrefs also making it more robust for the future.

There is also a ticket for changing everything over to use this technique: https://bugzilla.gnome.org/show_bug.cgi?id=615982
Comment 2 Martin Pitt 2012-10-04 07:03:40 UTC 
Thanks Alban! I committed this with a slightly refined changelog. Let's keep bug 615982 for converting everything to stack allocation.