GNOME Bugzilla – Bug 685050
Make devices visually distinct
Last modified: 2021-05-26 09:26:31 UTC
Right now, the main view contains a list which includes devices as well as folders. I think we should make devices look different from other entries - this will make it clearer what is going on. Perhaps making the background darker would be enough. Always placing devices at the top of the list would also help.
they are always on top of the list :) That said I agree that we should make the distinction more explicit, but I am not sure the different background would help and/or look very good. I think the distinction should be made by providing different information on the right hand size of the line since the current level bar etc does not really make perfect sense for a folder. I tried leaving it empty but it looked bad.,,,
(In reply to comment #1) > I think the distinction should be made by providing different information on > the right hand size of the line since the current level bar etc does not really > make perfect sense for a folder. I tried leaving it empty but it looked bad.,,, but now it's not empty anymore, there is an arrow ;-) The level bar as it is does not really make sense for folders, if possible could we try to remove it for 3.6.1?
Created attachment 225420 [details] [review] Add new volumes on top of the location list Otherwise new devices connected while baobab is running would be appended at the end of the list
Review of attachment 225420 [details] [review]: I did not test it but prepending does not look correct to me: the "main computer volume" should always stay first and the newly added volumes should be appended after the other volumes. Basically we should scan the list for the Home location and insert right before
(In reply to comment #4) > Review of attachment 225420 [details] [review]: > > I did not test it but prepending does not look correct to me: the "main > computer volume" should always stay first and the newly added volumes should be > appended after the other volumes. > > Basically we should scan the list for the Home location and insert right before I think, too, that the main volume should come first, but in the mockup there is a USB device before "Joe's computer"... which made me feel allowed to choose the lazy way and just prepend :)
(In reply to comment #2) ... > The level bar as it is does not really make sense for folders, if possible > could we try to remove it for 3.6.1? Removing the bars might make sense, (In reply to comment #4) > Review of attachment 225420 [details] [review]: > > I did not test it but prepending does not look correct to me: the "main > computer volume" should always stay first and the newly added volumes should be > appended after the other volumes. > > Basically we should scan the list for the Home location and insert right before I don't have a strong view on where extra devices should go, provided that the items for the XDG folders are placed below the volume that contains them.
Created attachment 225592 [details] [review] Append new volumes before the "Home folder" location
Created attachment 225594 [details] [review] Append new volumes before the "Home folder" location
Review of attachment 225594 [details] [review]: Looks good
Created attachment 225672 [details] [review] Show the usage level bar only for volumes
Review of attachment 225672 [details] [review]: I am not 100% sure about simply showing nothing for folders... As a user I still want to know if "Downloads" has enough space to put fedora.iso there. Maybe it is enough to find a way to write that folder X is on volume Y. Anyway I think this should wait for 3.8 Can you attach a screenie?
Comment on attachment 225594 [details] [review] Append new volumes before the "Home folder" location Attachment 225594 [details] pushed as f3895ad - Append new volumes before the "Home folder" location
Comment on attachment 225672 [details] [review] Show the usage level bar only for volumes Attachment 225672 [details] pushed as 74860f7 - Show the usage level bar only for volumes
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Baobab, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/baobab/-/issues/ Thank you for your understanding and your help.