GNOME Bugzilla – Bug 685048
"Main volume" isn't a good name for a drive
Last modified: 2013-07-24 09:23:03 UTC
I don't know what "Main volume" means, and I doubt other people will. If the volumet contains / as well as /home, we should name it after the computer name (eg. Joe's computer). If it is / and there is a separate home partition, name the volume after the OS (eg. Fedora 18).
Created attachment 225349 [details] [review] Replace "Main volume" with hostname As requested by designers. Fallback to the less cryptic "Computer" in case of error
Created attachment 225352 [details] [review] Replace "Main volume" with hostname As requested by designers. Fallback to the less cryptic "Computer" in case of error Try first with PrettyHostname, as in g-c-c
Review of attachment 225352 [details] [review]: Patch looks mostly good, though I would prefer to see the logic factored out in an helper method so that we can "hide" the scary dbus implementation :) For 3.6 we could fall back to the old "Main Volume" to not break string freeze and use the "Computer" fallback for master
Created attachment 225380 [details] [review] Replace "Main volume" with hostname when available As requested by designers.
Review of attachment 225380 [details] [review]: Looks good. Let's keep this bug open to remember to change the fallback as soon as we branch
Comment on attachment 225380 [details] [review] Replace "Main volume" with hostname when available Attachment 225380 [details] pushed as 039c1e0 - Replace "Main volume" with hostname when available
Created attachment 249695 [details] [review] Use better fallback name for main volume Do we still agree that "Computer" is a better fallback than "Main volume"?
Well I think it's ok since it's the same label used by GtkSideBar Attachment 249695 [details] pushed as a8dd25f - Use better fallback name for main volume