After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684993 - Optimise capture of preview
Optimise capture of preview
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-27 18:40 UTC by Bastien Nocera
Modified: 2012-10-10 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: Optimise preview for the usual shell layout (6.91 KB, patch)
2012-09-27 23:28 UTC, Bastien Nocera 		none Details | Review
background: Optimise preview for the usual shell layout (7.06 KB, patch)
2012-09-28 08:30 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2012-09-27 18:40:04 UTC 
Instead of capturing the whole monitor, and removing the workarea, capture anything on the first monitor that's not part of the work area.
Comment 1 William Jon McCann 2012-09-27 20:35:14 UTC 
I didn't do this because the non-workarea may not be contiguous. Say for example in fallback mode or with certain shell extensions.
Comment 2 Bastien Nocera 2012-09-27 22:34:00 UTC 
(In reply to comment #1)
> I didn't do this because the non-workarea may not be contiguous. Say for
> example in fallback mode or with certain shell extensions.

Couldn't you end up with bits from the user's current background in both cases then?
Comment 3 Bastien Nocera 2012-09-27 23:28:05 UTC 
Created attachment 225299 [details] [review]
background: Optimise preview for the usual shell layout

The area of screen to capture would be a ribbon at the top, so just
capture that instead of the whole screen, just to clear it afterwards.
Comment 4 Bastien Nocera 2012-09-28 08:30:50 UTC 
Created attachment 225317 [details] [review]
background: Optimise preview for the usual shell layout

The area of screen to capture would be a ribbon at the top, so just
capture that instead of the whole screen, just to clear it afterwards.
Comment 5 Bastien Nocera 2012-10-10 16:57:25 UTC 
Attachment 225317 [details] pushed as 0e03756 - background: Optimise preview for the usual shell layout