After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684935 - region: build IBus setup app filename only from the engine prefix
region: build IBus setup app filename only from the engine prefix
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-27 08:58 UTC by Daiki Ueno
Modified: 2012-10-02 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
region: build IBus setup app filename only from the engine prefix (2.17 KB, patch)
2012-09-27 08:58 UTC, Daiki Ueno
committed Details | Review

Description Daiki Ueno 2012-09-27 08:58:31 UTC
There are 84 m17n engines in the whitelist and they all use
ibus-setup-m17n.  To reduce the number of .desktop files, this
patch uses the prefix before the first ":" to construct the .desktop
filename and set IBUS_ENGINE_NAME envvar to let the setup app know
the actual engine ID.
Comment 1 Daiki Ueno 2012-09-27 08:58:33 UTC
Created attachment 225248 [details] [review]
region: build IBus setup app filename only from the engine prefix
Comment 2 Rui Matos 2012-09-27 14:52:38 UTC
Review of attachment 225248 [details] [review]:

Yep, this looks fine, thanks.

I don't see a setup tool for m17n though, not in the fedora packages nor upstream. Are you going to provide one?
Comment 3 Daiki Ueno 2012-09-28 01:20:16 UTC
(In reply to comment #2)
> I don't see a setup tool for m17n though, not in the fedora packages nor
> upstream. Are you going to provide one?

Yes, https://codereview.appspot.com/6572062/
Comment 4 Matthias Clasen 2012-09-29 14:16:20 UTC
What needs to be configured in all m17n engines ?

I think we ideally want to keep per-engine configurability to a minimum.
Comment 5 Daiki Ueno 2012-09-29 15:10:40 UTC
(In reply to comment #4)
> What needs to be configured in all m17n engines ?

The common settings in all m17n engines are:

- pre-edit appearance
  some language users want pre-edit to be decorated but others don't
- look up table orientation

In addition, there are pre-engine configuration in m17n engines theirselves.
You could check it with:

$ grep -A5 "^(variable" /usr/share/m17n/*.mim | less

For example, Thai engines only have "acceptance-level" setting of input words (which is needed).

> I think we ideally want to keep per-engine configurability to a minimum.

I know and I think the current options are well designed to be minimum, for m17n engines.
Comment 6 Rui Matos 2012-10-02 14:54:38 UTC
Attachment 225248 [details] pushed as fb6c89f - region: build IBus setup app filename only from the engine prefix