GNOME Bugzilla – Bug 684924
rtspsrc: flush connection when going to null state
Last modified: 2013-02-06 12:42:52 UTC
Connection is not flushed if we are going to NULL state (and calling gst_rtspsrc_stop). This means that if the gstrtspsrc task is in the middle of opening the connection it might get stuck, for example, in gst_rtspsrc_try_send. In this example, gst_rtspsrc_stop will block for 20 seconds waiting for the thread to complete.
Created attachment 225238 [details] [review]
flush connection when going to null
Any comments on this patch?
It has been working successfully for a couple of months now.
The _send_cmd() method is supposed to flush the connection when asked to so I moved that logic there.
Author: Wim Taymans <firstname.lastname@example.org>
Date: Wed Feb 6 13:10:33 2013 +0100
rtspsrc: always flush connection in stop
Use the flush argument in the send_cmd method to force a flush of the
connection. We only want to flush the connection when stopping so that
we can stop and join the task.