After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684880 - keyboard repeat does not work for screen brightness and keyboard backlight control keys
keyboard repeat does not work for screen brightness and keyboard backlight co...
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
3.4.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-26 14:15 UTC by Romain Riviere
Modified: 2012-12-20 20:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gsd: add keyboard repeat to brightness keys (687 bytes, patch)
2012-10-08 09:17 UTC, Romain Riviere
none Details | Review
Updated patch against git master (1.24 KB, patch)
2012-11-14 13:55 UTC, Alex Murray
committed Details | Review

Description Romain Riviere 2012-09-26 14:15:16 UTC
Keyboard repeat is enabled and works fine with volume keys. However, it does not for LCD brightness or keyboard backlight.

Using repeat on these keys is quite handy, so I believe it should be enabled. As a workaround, it should be possible to disable handling of these keys by gnome-shell, so that 3rd-party tools where repeat works (such as pommed) might handle them.

Hardware: Apple MacBook Pro 5,3
Kernel 3.5.4
Xorg evdev driver, model macbook78, layout fr
Comment 1 Florian Müllner 2012-09-26 14:55:36 UTC
Those keys are handled by gnome-settings-dameon's media-keys plugin. Reassigning.
Comment 2 Romain Riviere 2012-10-08 09:17:03 UTC
Created attachment 226022 [details] [review]
gsd: add keyboard repeat to brightness keys
Comment 3 Romain Riviere 2012-10-08 09:18:50 UTC
The patch above works for me. It was diff'ed against gsd 3.4.2 but it is trivial and should apply to future versions without a problmem.
Comment 4 Alex Murray 2012-11-14 13:55:43 UTC
Created attachment 228969 [details] [review]
Updated patch against git master

Would be great to see this incorporated to make all these media keys work the same - at the moment the inconsistencies are quite annoying - perhaps this would qualify as an Every Details Matters bug??
Comment 5 Alex Murray 2012-12-20 13:09:21 UTC
@g-s-d maintainers - can anyone comment on this patch?
Comment 6 Alex Murray 2012-12-20 13:26:01 UTC
After conversing with cosimoc on #gnome-design it seems that the repeated keys is the expected behaviour for the screen and keyboard backlight keys as well so I guess a. there is a bug in g-s-d since it currently doesn't work that way and b. this patch (for both myself and @Romain who originally reported this issue) fixes the bug - so would be great to hear from @hadess or similar regarding this - thanks.
Comment 7 Filippo Argiolas 2012-12-20 14:14:08 UTC
Would it be too much to ask to backport it to 3.6? this is one of my big annoyances in fedora 18 (mainly because I cannot find a way to make it remember brightness settings after reboot and I have to hit the dim key plenty of times to turn off the keyboard backlight at each login... macbook pro 7,1, not sure if there's a bug for that, couldn't find it, will open one soon)
Comment 8 Bastien Nocera 2012-12-20 14:32:10 UTC
(In reply to comment #7)
> Would it be too much to ask to backport it to 3.6? this is one of my big
> annoyances in fedora 18 (mainly because I cannot find a way to make it remember
> brightness settings after reboot and I have to hit the dim key plenty of times
> to turn off the keyboard backlight at each login... macbook pro 7,1, not sure
> if there's a bug for that, couldn't find it, will open one soon)

Filing bugs for the causes would be nicer than relying on work-arounds, certainly.
Comment 9 Bastien Nocera 2012-12-20 14:36:21 UTC
It's in gnome-3-6 now.
Comment 10 Filippo Argiolas 2012-12-20 14:49:10 UTC
(In reply to comment #8)
> Filing bugs for the causes would be nicer than relying on work-arounds,
> certainly.

I know, I know ;) I'm sorry! I was looking for a bug in g-s-d, now I found one in g-p-m and commented there, not sure it belongs there though https://bugzilla.gnome.org/show_bug.cgi?id=688706


(In reply to comment #9)
> It's in gnome-3-6 now.

Thank you!
Comment 11 Bastien Nocera 2012-12-20 14:54:03 UTC
(In reply to comment #10)
> (In reply to comment #8)
> > Filing bugs for the causes would be nicer than relying on work-arounds,
> > certainly.
> 
> I know, I know ;) I'm sorry! I was looking for a bug in g-s-d, now I found one
> in g-p-m and commented there, not sure it belongs there though
> https://bugzilla.gnome.org/show_bug.cgi?id=688706

gnome-power-manager contains no code of interest (and unless you upgraded, it's likely it's not even installed).
Comment 12 Filippo Argiolas 2012-12-20 20:48:40 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #8)
> > > Filing bugs for the causes would be nicer than relying on work-arounds,
> > > certainly.
> > 
> > I know, I know ;) I'm sorry! I was looking for a bug in g-s-d, now I found one
> > in g-p-m and commented there, not sure it belongs there though
> > https://bugzilla.gnome.org/show_bug.cgi?id=688706
> 
> gnome-power-manager contains no code of interest (and unless you upgraded, it's
> likely it's not even installed).

Good to know, thanks. I had it installed from fedora 17, removed now.