GNOME Bugzilla – Bug 684819
"Connect to a Hidden Network" doesn't look actionable
Last modified: 2012-10-09 08:23:45 UTC
The "Connect to a hidden Network" row doesn't look actionable, as it doesn't have a right arrow at the end. Also, the fact that it's displayed in bold before the out of range networks makes it look more like a heading for that section than a clickable row. I think it would be nice to add some vertical padding around it, and also an arrow button.
Arrow button doesn't sound right to me. This doesn't go to a details page directly, but pops up a dialog. I think having noticable hover for the left sides of the row would address this. Maybe make it bold only on hover ? And then, do the same for APs that can be activated by clicking on the name ?
This bug is largely a consequence of not having the correct widgetry to do this kind of UI. Ideally, list rows would have separators and styling that would invite interaction. For now, I wonder if it would be better to simply make Connect to a Hidden Network a button outside the list (horizontally aligned with Use as Hotspot...).
Created attachment 225452 [details] [review] patch
Created attachment 225453 [details] screenshot The button text is a bit long, otherwise looks ok to me
(In reply to comment #4) > Created an attachment (id=225453) [details] > screenshot > > The button text is a bit long, otherwise looks ok to me The text seems OK to me. I'd maybe right align the button to the other edge of the list though.
With better arrows, we could avoid having to use a button for this functionality, which I would prefer to this current patch.
I still don't think an arrow is right for this at all. It opens a dialog, and doesn't switch to a different page, like all the other arrows do.
Created attachment 225670 [details] [review] Use a regular button for 'Connect to Hidden' The treeview is not really up to this level of custom UI.
Created attachment 225671 [details] [review] network: Use a regular button for 'Connect to Hidden' The treeview is not really up to this level of custom UI.
Comment on attachment 225671 [details] [review] network: Use a regular button for 'Connect to Hidden' Attachment 225671 [details] pushed as ea0f359 - network: Use a regular button for 'Connect to Hidden'
Comment on attachment 225670 [details] [review] Use a regular button for 'Connect to Hidden' This is for 3.8, because of the new string.
Removing from the whiteboard as it's fixed in master for GNOME 3.6.
Comment on attachment 225670 [details] [review] Use a regular button for 'Connect to Hidden' Would have been better if I didn't forget the UI file in the patch.
Fixed the string in master.