After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684810 - Text fields in password dialogs expand behavior inconsistent
Text fields in password dialogs expand behavior inconsistent
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-25 19:11 UTC by Cosimo Cecchi
Modified: 2012-11-12 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyring (100.26 KB, image/jpeg)
2012-09-25 19:12 UTC, Cosimo Cecchi 		  Details
mount operation (96.22 KB, image/jpeg)
2012-09-25 19:12 UTC, Cosimo Cecchi 		  Details
polkit (84.48 KB, image/jpeg)
2012-09-25 19:12 UTC, Cosimo Cecchi 		  Details
polkitAgent: Expand password entry to the full width (1.30 KB, patch)
2012-11-07 17:11 UTC, Florian Müllner 		committed Details | Review

Description Cosimo Cecchi 2012-09-25 19:11:53 UTC 
The horizontal expand behavior for text fields in password dialogs is inconsistent: AFAICS all dialogs except the polkit one expand it.

I don't know which one is best (I think I prefer the expanded version), but I think we should be consistent.
Comment 1 Cosimo Cecchi 2012-09-25 19:12:26 UTC 
Created attachment 225162 [details]
keyring
Comment 2 Cosimo Cecchi 2012-09-25 19:12:42 UTC 
Created attachment 225163 [details]
mount operation
Comment 3 Cosimo Cecchi 2012-09-25 19:12:56 UTC 
Created attachment 225164 [details]
polkit
Comment 4 Allan Day 2012-11-07 16:26:44 UTC 
I agree - they should all be expanded.
Comment 5 Florian Müllner 2012-11-07 17:11:43 UTC 
Created attachment 228393 [details] [review]
polkitAgent: Expand password entry to the full width

Due to an oversight, the width of the password entry is currently
determined by the length of the message description. Fix the flags
so that the entry spans the entire width of the dialog.

(Gah, I had looked at the bug before, but couldn't reproduce - "pkexec true" makes a pure test case here :-))
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-11-07 18:04:48 UTC 
Review of attachment 228393 [details] [review]:

g
Comment 7 Aleksandr Stepanov 2012-11-12 00:32:27 UTC 
password dialog must be displayed in way as messages in tray.
not all of them, but many. imho.

especially wifi and im reqests passphrase (then i lost connection) annoying me.
especially then i am typing, i accidentally rewrite my saved passwords, and this popub alerts back again.

for other dialogs sometime i want to be alerted,  sometimes not, but I do not mind to putting all dialogs to tray is bad.
Comment 8 Aleksandr Stepanov 2012-11-12 00:43:09 UTC 
password dialog must be displayed in way as messages in tray.
not all of them, but many. imho.

especially wifi and im reqests passphrase (then i lost connection) annoying me.
especially then i am typing, i accidentally rewrite my saved passwords, and this popub alerts back again.

for other dialogs sometime i want to be alerted,  sometimes not, but I do not mind to putting all dialogs to tray is bad.
Comment 9 Florian Müllner 2012-11-12 16:00:22 UTC 
Attachment 228393 [details] pushed as 15e1470 - polkitAgent: Expand password entry to the full width