After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684750 - libgdm: don't ever user switch to closing login screen
libgdm: don't ever user switch to closing login screen
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-25 01:54 UTC by Ray Strode [halfline]
Modified: 2012-09-25 18:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libgdm: don't ever user switch to closing login screen (3.20 KB, patch)
2012-09-25 01:54 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2012-09-25 01:54:21 UTC 
bugs in login screen service can mean stray processes
laying around keeping the login screen session on life
support in a "closing" state.

libgdm will try to user switch to these defunct sessions.

This commit fixes that.
Comment 1 Ray Strode [halfline] 2012-09-25 01:54:23 UTC 
Created attachment 225117 [details] [review]
libgdm: don't ever user switch to closing login screen
Comment 2 Matthias Clasen 2012-09-25 01:56:43 UTC 
Looks reasonable as a robustness measure. We should still find a way to kill greeter sessions reliably...
Comment 3 Matthias Clasen 2012-09-25 10:10:42 UTC 
I've talked a bit on #a11y last night, and it seems the basic problem is that speech-dispatcher daemonizes, causing it to escape our killing of the process group. It has a mode in which it doesn't, which could probably be made to work for orca.
Comment 4 Matthias Clasen 2012-09-25 10:10:58 UTC 
Approval 1 for this patch, anyway.
Comment 5 Ray Strode [halfline] 2012-09-25 18:00:02 UTC 
Attachment 225117 [details] pushed as 1fd23f7 - libgdm: don't ever user switch to closing login screen