After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684736 - Do not use gst_bus_poll()
Do not use gst_bus_poll()
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Thumbnailer
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-09-24 19:23 UTC by Javier Jardón (IRC: jjardon)
Modified: 2012-09-25 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use-gst_bus_timed_pop_filtere-instead-gst_bus_poll (883 bytes, patch)
2012-09-24 19:24 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Unref-GstBus-after-usage (1.85 KB, patch)
2012-09-24 19:24 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
bacon-video-widget.c-Use-gst_bus_pop_filtered-instea (1.08 KB, patch)
2012-09-24 19:25 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2012-09-24 19:23:55 UTC 
As the documentation said:

"You should never use this function, since it is pure evil"
Comment 1 Javier Jardón (IRC: jjardon) 2012-09-24 19:24:26 UTC 
Created attachment 225089 [details] [review]
Use-gst_bus_timed_pop_filtere-instead-gst_bus_poll
Comment 2 Javier Jardón (IRC: jjardon) 2012-09-24 19:24:51 UTC 
Created attachment 225091 [details] [review]
Unref-GstBus-after-usage
Comment 3 Javier Jardón (IRC: jjardon) 2012-09-24 19:25:18 UTC 
Created attachment 225092 [details] [review]
bacon-video-widget.c-Use-gst_bus_pop_filtered-instea
Comment 4 Tim-Philipp Müller 2012-09-24 19:32:22 UTC 
♥
Comment 5 Bastien Nocera 2012-09-25 10:55:31 UTC 
Review of attachment 225089 [details] [review]:

++
Comment 6 Bastien Nocera 2012-09-25 10:56:49 UTC 
Review of attachment 225091 [details] [review]:

::: src/totem-video-thumbnailer.c
@@ +308,1 @@
+	return async_recieved;

Did you even try to compile this? I think not.
Comment 7 Bastien Nocera 2012-09-25 11:01:49 UTC 
Review of attachment 225092 [details] [review]:

++
Comment 8 Bastien Nocera 2012-09-25 11:10:01 UTC 
Committed after fixing the commit subject lines, and the typo in the 2nd patch.