GNOME Bugzilla – Bug 684730
'log in as different user' not read well by orca at all
Last modified: 2012-10-12 14:32:02 UTC
When you click on this (you can't keynav to it, which is a different issue), you get to a screen with a username entry. Orca reads that as just 'text'. Then, if you focus to the buttons, it reads them as just 'push button'.
actually, you can't even focus the buttons...
Created attachment 226204 [details] [review] loginDialog: Use the same focus root for dialog and ctrl-alt-tab Adding a group to the Ctrl-Alt-Tab popup will also add it to the focus manager. Due to that, we currently end up with two focus groups added for the login dialog - an explicit one for the entire dialog, and an implicit one for the main content group. When doing keynav, we ascend in the widget hierarchy from the currently focused actor until we find a valid focus root, so adding a children of the dialog as focus root breaks keynav to any actors that are not inside the main content group. The simple fix is to use the same group in both cases.
Created attachment 226205 [details] [review] loginDialog: Add focus indication While keynav works on login screen and unlock dialog, most elements currently miss a focus indication.
(In reply to comment #0) > When you click on this (you can't keynav to it, which is a different issue), > you get to a screen with a username entry. Orca reads that as just 'text'. > Then, if you focus to the buttons, it reads them as just 'push button'. With the attached patches (well, only the first actually), I can keynav to any element on the login screen. I cannot reproduce the issue with missing a11y-labels though - when I activate Orca, everything read makes some sense to me ... (tested with current master + patches in bug 685201 + patches in this bug)
Works fine in my testing as well.
Can I get review on this? Both patches are fairly straightforward.
Review of attachment 226204 [details] [review]: This looks like a simple oversight. Easy enough.
Review of attachment 226205 [details] [review]: This too.
Attachment 226204 [details] pushed as 3abfcda - loginDialog: Use the same focus root for dialog and ctrl-alt-tab Attachment 226205 [details] pushed as 8cc54ce - loginDialog: Add focus indication (In reply to comment #5) > Works fine in my testing as well. OK, so let's close this for now ...
awesome