After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684675 - private-chat-$UUID rooms are created with default (i.e. public) settings
private-chat-$UUID rooms are created with default (i.e. public) settings
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Multi User Chat
3.5.x
Other Linux
: Normal normal
: 3.6
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-23 18:26 UTC by Roman Yepishev
Modified: 2012-09-25 07:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tp-chat: set Private and InviteOnly props on conference channels (2.37 KB, patch)
2012-09-24 08:39 UTC, Guillaume Desmottes 		committed Details | Review

Description Roman Yepishev 2012-09-23 18:26:12 UTC 
In case the XMPP server supports MUC, empathy will create the room called private-chat-$UUID following GTalk, however it is created with default settings and therefore is publicly visible in the conference list and open to everybody to join.

GTalk server does not list the available conferences (and it is using custom XMPP MUC settings) but other XMPP servers have a directory of current chats. The "private-chat-..." created in Empathy will be completely open for public.
Comment 1 Guillaume Desmottes 2012-09-24 08:39:16 UTC 
Good catch, thanks for the report.
Comment 2 Guillaume Desmottes 2012-09-24 08:39:25 UTC 
Created attachment 225044 [details] [review]
tp-chat: set Private and InviteOnly props on conference channels

Only the person invited are suppose to join these channels so tweak their
settings to make them more secure.
Comment 3 Guillaume Desmottes 2012-09-24 09:15:46 UTC 
Comment on attachment 225044 [details] [review]
tp-chat: set Private and InviteOnly props on conference channels

Approved by Xavier on IRC. I'll merge once the hard code freeze is over.
Comment 4 Guillaume Desmottes 2012-09-25 07:32:27 UTC 
Merged, will be in 3.6.1

Attachment 225044 [details] pushed as b399609 - tp-chat: set Private and InviteOnly props on conference channels