GNOME Bugzilla – Bug 684667
Improve the documentation of AtkObject::children-changed
Last modified: 2013-10-24 10:32:16 UTC
Some meetings ago we concluded that the index can be -1 in some cases. During the Randa Sprint I also realized that the reference to the object can be NULL (ie: it is used on the implementation of gtktreeviewaccessible). Again, some day we would need to review the concept of children-changed and check if it really worths to emit one signal each time an object appears, as in several cases that can be irrelevant.
Created attachment 225029 [details] [review] Fixes the bug Added the documentation at the template files, although as I said on 684665, ideally this should be at the source file itself.
Have just committed a similar patch to the one I uploaded on comment 1. Closing bug.
I had a quick chat with Mario Sanchez and mentioned that he has been having a lot of problems having the accessible child when this is removed. This makes sense, because if the child is being removed, there is a possibility that the child is not available. Looking at the description of the bug, I also mentioned it. Looking at the fix, I only covered the possibility of -1 as index. Reopening.
Created attachment 257999 [details] [review] Documents the possibility of NULL for a child removed
New documentation added. Closing bug (again).