After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684661 - Translate date formats
Translate date formats
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-23 14:20 UTC by Frederic Peters
Modified: 2012-09-23 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Translate date formats (863 bytes, patch)
2012-09-23 14:20 UTC, Frederic Peters 		accepted-commit_now Details | Review

Description Frederic Peters 2012-09-23 14:20:56 UTC 
Currently the date formats are marked for translation (N_) but they are not
passed to gettext when actually used in nautilus_file_get_date_as_string.
Comment 1 Frederic Peters 2012-09-23 14:20:59 UTC 
Created attachment 225022 [details] [review]
Translate date formats
Comment 2 Cosimo Cecchi 2012-09-23 14:27:57 UTC 
Review of attachment 225022 [details] [review]:

Looks good to me, thanks; do we need to go through the r-t approval process for this? Otherwise please push to git master.
Comment 3 Matthias Clasen 2012-09-23 14:57:09 UTC 
Yes, please ask for a freeze break, and cc gnome-i18n to keep translators in the loop (though this is not a string break)
Comment 4 André Klapper 2012-09-23 15:17:31 UTC 
r-t approval 1 of 2.
Comment 5 Frederic Peters 2012-09-23 17:07:55 UTC 
I sent an email to rt and translators.
Comment 6 Frederic Peters 2012-09-23 19:19:05 UTC 
I have now pushed the patch.