After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684642 - Set an empty title on the info dialog
Set an empty title on the info dialog
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-23 00:06 UTC by Matthias Clasen
Modified: 2012-09-26 18:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (990 bytes, patch)
2012-09-23 00:06 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2012-09-23 00:06:06 UTC 
Created attachment 225007 [details] [review]
patch

Currently, it shows up with 'gnome-font-viewer' in the titlebar,
which looks ugly.
Comment 1 Cosimo Cecchi 2012-09-23 14:35:12 UTC 
Review of attachment 225007 [details] [review]:

Looks good to me, thanks. Do you feel it's worth to request a freeze break to get this in 3.6.0?

[ I feel that GTK could be smarter when NULL is passed as a title to a GtkDialog though...if the dialog is modal like in this case, there's no real reason to default to the binary name like that ]
Comment 2 Matthias Clasen 2012-09-23 14:51:24 UTC 
No, I don't think it needs a freeze break, fine for 3.6.1
Comment 3 Cosimo Cecchi 2012-09-26 18:41:12 UTC 
Pushed now