After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684633 - Add message tray to Ctrl-Alt-Tab
Add message tray to Ctrl-Alt-Tab
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.6.1
Depends on:
Blocks:
 
 
Reported: 2012-09-22 18:15 UTC by Matthias Clasen
Modified: 2012-10-03 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
messageTray: Show the message tray in Ctrl+Alt+Tab outside of the overview (2.38 KB, patch)
2012-09-22 18:30 UTC, Jasper St. Pierre (not reading bugmail)
needs-work Details | Review
messageTray: Show the message tray in Ctrl+Alt+Tab outside of the overview (2.42 KB, patch)
2012-09-25 20:19 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
ctrlAltTab: Only set the stage focus mode when we're focusing a widget (1.57 KB, patch)
2012-10-02 22:22 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Matthias Clasen 2012-09-22 18:15:23 UTC
In the overlay, a whole bunch of things appear in the Ctrl-Alt-Tab popup, including the message tray. Outside the overview, the popup has only the Top bar. Now that the message tray is keynavigatable, it should show up there too.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-09-22 18:21:38 UTC
I asked rishi about this when it landed ( https://bugzilla.gnome.org/show_bug.cgi?id=681519#c8 ). I forget his reasoning, but it had to do with <Super>M.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-09-22 18:30:32 UTC
Created attachment 224992 [details] [review]
messageTray: Show the message tray in Ctrl+Alt+Tab outside of the overview

Since the message tray is accessible outside of the overview, it doesn't
make sense to show it only there.
Comment 3 Rui Matos 2012-09-22 20:56:56 UTC
Review of attachment 224992 [details] [review]:

::: js/ui/messageTray.js
@@ +2054,3 @@
                     });
 
+        // Don't move the windows up if we are in the overview.

You still need to return early here.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-09-25 20:19:19 UTC
Created attachment 225173 [details] [review]
messageTray: Show the message tray in Ctrl+Alt+Tab outside of the overview

Since the message tray is accessible outside of the overview, it doesn't
make sense to show it only there.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-10-02 19:14:41 UTC
Does this make sense for 3.6.1? Review?
Comment 6 Rui Matos 2012-10-02 21:45:49 UTC
Review of attachment 225173 [details] [review]:

When activating the tray this way the currently focused window loses focus. That doesn't happen when activating it through dwelling or the hotkey.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-10-02 22:22:06 UTC
Created attachment 225638 [details] [review]
ctrlAltTab: Only set the stage focus mode when we're focusing a widget

This ensures that we don't accidentally lose focus when switching to
the message tray.
Comment 8 Rui Matos 2012-10-03 11:41:23 UTC
Review of attachment 225173 [details] [review]:

Ok, the code looks fine and now works correctly with the other patch.
Comment 9 Rui Matos 2012-10-03 11:45:46 UTC
Review of attachment 225638 [details] [review]:

Yes, this seems ok and works on all current ctrl+alt+tab users.
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-10-03 16:05:06 UTC
Attachment 225173 [details] pushed as 4485170 - messageTray: Show the message tray in Ctrl+Alt+Tab outside of the overview
Attachment 225638 [details] pushed as a171e92 - ctrlAltTab: Only set the stage focus mode when we're focusing a widget