After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684585 - systemd: check for greeter by looking at class not service
systemd: check for greeter by looking at class not service
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
3.6.1
Depends on:
Blocks:
 
 
Reported: 2012-09-21 20:52 UTC by Ray Strode [halfline]
Modified: 2012-09-29 22:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
systemd: check for greeter by looking at class not service (1.71 KB, patch)
2012-09-21 20:52 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2012-09-21 20:52:51 UTC 
GDM calls its pam service file gdm-launch-environment not gdm-welcome,
so the current login session detection code is broken. It's fragile anyway.

A much better approach is to query if the session class is "greeter".

This commit does that.
Comment 1 Ray Strode [halfline] 2012-09-21 20:52:52 UTC 
Created attachment 224951 [details] [review]
systemd: check for greeter by looking at class not service
Comment 2 Ray Strode [halfline] 2012-09-21 20:54:02 UTC 
Comment on attachment 224951 [details] [review]
systemd: check for greeter by looking at class not service

I don't think we need to break hard code freeze for this (seems to mostly affect error conditions from reading through the code) so marking it for after freeze .
Comment 3 Matthias Clasen 2012-09-29 22:00:00 UTC 
Attachment 224951 [details] pushed as c8253d1 - systemd: check for greeter by looking at class not service