After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684582 - keyboard: Create sources from X layouts in use when setting is empty
keyboard: Create sources from X layouts in use when setting is empty
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks: 684586
 
 
Reported: 2012-09-21 19:49 UTC by Rui Matos
Modified: 2012-09-30 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keyboard: Create sources from X layouts in use when setting is empty (3.30 KB, patch)
2012-09-21 19:49 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2012-09-21 19:49:20 UTC
Patch attached.
Comment 1 Rui Matos 2012-09-21 19:49:21 UTC
Created attachment 224948 [details] [review]
keyboard: Create sources from X layouts in use when setting is empty

If the input sources setting is empty we populate it on startup with
the current XKB layouts currently configured on the X server so that
they are immediately available as regular input sources.
Comment 2 Bastien Nocera 2012-09-21 20:06:07 UTC
Review of attachment 224948 [details] [review]:

Looks good, please file a bug to get the gnome-control-center code removed.
Comment 3 Rui Matos 2012-09-22 13:54:22 UTC
Got freeze break approval:
https://mail.gnome.org/archives/release-team/2012-September/msg00244.html

Attachment 224948 [details] pushed as 1929d44 - keyboard: Create sources from X layouts in use when setting is empty
Comment 4 Jeremy Nickurak 2012-09-30 13:38:55 UTC
What should we observe to confirm that this fix is working? (I haven't been able to confirm any change in behavior yet).