After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684581 - Drop TotemScrSaver
Drop TotemScrSaver
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
git master
Other All
: Normal enhancement
: GNOME3.8
Assigned To: Felix Riemann
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-21 19:37 UTC by Felix Riemann
Modified: 2012-10-02 17:29 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
0001-Use-GtkApplication-to-inhibit-the-screensaver-during.patch (7.07 KB, patch)
2012-09-23 16:06 UTC, Felix Riemann
reviewed Details | Review
0002-Drop-now-unneeded-TotemScrSaver.patch (18.69 KB, patch)
2012-09-23 16:07 UTC, Felix Riemann
reviewed Details | Review

Description Felix Riemann 2012-09-21 19:37:35 UTC
Currently eog uses the TotemScrSaver classes from Totem to prevent the screensaver from kicking in during a slideshow.

As of gtk+-3.4 this can also be done through GtkApplication using the gtk_application_inhibit() call.

By switching we could drop TotemScrSaver from eog, as has done Totem itself already.

Examples on how to do this can be found in Evince[1] and Totem[2].

1: http://git.gnome.org/browse/evince/commit/?id=612701ffdcefead69937940e7b3b202aa8e59765

2: http://git.gnome.org/browse/totem/commit/?id=1c9970511b8691012b284a5ae02190f4405e332c
Comment 1 Felix Riemann 2012-09-23 16:06:09 UTC
Created attachment 225027 [details] [review]
0001-Use-GtkApplication-to-inhibit-the-screensaver-during.patch

Use GtkApplication to inhibit the screensaver during slideshows

Realized in a similar fashion as in Evince and Totem.

https://bugzilla.gnome.org/show_bug.cgi?id=684581
Comment 2 Felix Riemann 2012-09-23 16:07:01 UTC
Created attachment 225028 [details] [review]
0002-Drop-now-unneeded-TotemScrSaver.patch

Drop now unneeded TotemScrSaver

It's not needed anymore GtkApplication does the job now.

https://bugzilla.gnome.org/show_bug.cgi?id=684581
Comment 3 Claudio Saavedra 2012-09-24 15:24:48 UTC
Review of attachment 225027 [details] [review]:

Looks good.
Comment 4 Claudio Saavedra 2012-09-24 15:26:31 UTC
Review of attachment 225028 [details] [review]:

Goodie good.
Comment 5 Felix Riemann 2012-10-02 17:29:13 UTC
commit 01c1055062a23a56dff951d9d9e41a0605a8509b
Author: Felix Riemann <>
Date:   Sun Sep 23 17:56:08 2012 +0200

    Drop now unneeded TotemScrSaver
    
    It's not needed anymore since GtkApplication does the job now.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684581

commit e8b50ab48a5a068ee56a29f9709b499d03781d4a
Author: Felix Riemann <>
Date:   Sun Sep 23 17:50:02 2012 +0200

    Use GtkApplication to inhibit the screensaver during slideshows
    
    Realized in a similar fashion as in Evince and Totem.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684581
---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.