After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684568 - codecparsers: h264: fix error code for invalid size parsed in SPS
codecparsers: h264: fix error code for invalid size parsed in SPS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 685215
 
 
Reported: 2012-09-21 16:30 UTC by Gwenole Beauchesne
Modified: 2012-11-19 12:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codecparsers: h264: fix error code for invalid size parsed in SPS (1.17 KB, patch)
2012-09-21 16:30 UTC, Gwenole Beauchesne 		committed Details | Review

Description Gwenole Beauchesne 2012-09-21 16:30:41 UTC 
Created attachment 224940 [details] [review]
codecparsers: h264: fix error code for invalid size parsed in SPS

Hi, gst_h264_parse_sps() returned FALSE if it parsed invalid (negative) size components. Now make it gracefully return GST_H264_PARSER_ERROR instead of GST_H264_PARSER_OK (FALSE).

Not that I really tested it, just noticed the bug when factor it code for implementing subset_seq_parameter_set_rbsp().
Comment 1 Tim-Philipp Müller 2012-10-19 00:10:48 UTC 
Makes sense. Have you had a chance to test this patch yet?  (I'm guessing you might have been using it for a while now?)
Comment 2 Gwenole Beauchesne 2012-11-19 09:52:07 UTC 
Yes, I have been using it for a while now, but so far, I still haven't got by a stream presenting this kind of issue: one of the dimension is negative. Though, the patch looks trivial enough. :)
Comment 3 Tim-Philipp Müller 2012-11-19 12:54:41 UTC 
Yeah sorry, it was just the 'I haven't tested it' disclaimer that put me off at the time, these little things can sometimes have unexpected side effects :)

 commit c951d201ec88696157c7a5ad2de27e1b73b01e04
 Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
 Date:   Fri Sep 21 18:23:21 2012 +0200

    codecparsers: h264: fix error code for invalid size parsed in SPS.
    
    gst_h264_parse_sps() returned FALSE if it parsed invalid (negative)
    size components. Now make it gracefully return GST_H264_PARSER_ERROR
    instead of GST_H264_PARSER_OK (FALSE).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684568