After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684539 - Not setting language after start
Not setting language after start
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-09-21 11:06 UTC by Bastien Nocera
Modified: 2012-09-25 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
daemon: Call setlocale() before completing initialization (959 bytes, patch)
2012-09-21 11:11 UTC, Stef Walter 		committed Details | Review

Description Bastien Nocera 2012-09-21 11:06:59 UTC 
<stefw> but obviously now that you mention it, setting LANG via 'g-k-d --start' would never have worked.

Because we don't call setlocale() after setting the LANG, or LC_ALL through --start.

This breaks translations of gnome-keyring dialogue in gnome-shell.
Comment 1 Stef Walter 2012-09-21 11:11:57 UTC 
Created attachment 224917 [details] [review]
daemon: Call setlocale() before completing initialization

A new LANG environment variable can be received during late
initialization (from gnome-keyring-daemon --start). So call
setlocale() so that the new environment variable can take effect.
Comment 2 Stef Walter 2012-09-25 14:00:49 UTC 
Attachment 224917 [details] pushed as a807039 - daemon: Call setlocale() before completing initialization