It seems that the network configuration was forgotten (or matching with the AP fails), and we summon the control center because I suppose it's WPA enterprise.

but the control-center can't deal with it either :-(

Any info on stderr?
Something like
Network panel loaded with connect-8021x-wifi but the access point does not support 802.1x
?

It could be a stale AP entry that has the wrong flags (I'd blame the drivers in that case)

I'll have to test when I get to the office later, no enterprise wpa here at home...

I can reproduce this at the office - after clicking "Forget Network" in System Settings, selecting the AP in the network menu launches gnome-control-center, where there's no way to actually configure the network.
Launching nm-connection-editor and entering the configuration manually seems to work, until clicking safe just does nothing - this is pretty bad :-(

We do:

Util.spawn(['gnome-control-center', 'network', 'connect-8021x-wifi',        this.device.get_path(), accessPoints[0].dbus_path]);

when the AP is WPA or WPA2 Enterprise.

The question is why doesn't the control center do the right thing? Are the parameters (this.device.get_path() and accessPoints[0].dbus_path] wrong? (Cannot test here due to lack of AP) .. maybe printing them out with log might shed some light.

Otherwise this is a regression in gnome-control-center ...

Given that the network panel has been changed significantly this cycle, regressions are not too surprising - still bad for users :-)

thats the problem with commandline-apis - the other side is usually not aware what is used api, and what is just 'update the man page'...

  gnome-control-center -v network connect-8021x-wifi /org/freedesktop/NetworkManager/Devices/1/ org/freedesktop/NetworkManager/AccessPoint/129
Gtk-Message: Failed to load module "canberra-gtk-module"
** DEBUG: Enabling debugging
** DEBUG: Extra argument: connect-8021x-wifi
network-cc-panel-DEBUG: Invoked with operation connect-8021x-wifi
network-cc-panel-DEBUG: coldplugging devices
network-cc-panel-DEBUG: got proxy
network-cc-panel-DEBUG: device /sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/net/wlan0 type 2
network-cc-panel-DEBUG: adding Red Hat
network-cc-panel-DEBUG: adding Red Hat Guest
network-cc-panel-DEBUG: found duplicate: Red Hat Guest
network-cc-panel-DEBUG: removing Red Hat Guest
network-cc-panel-DEBUG: adding Red Hat Guest
network-cc-panel-DEBUG: found duplicate: Red Hat Guest
network-cc-panel-DEBUG: found duplicate: Red Hat
network-cc-panel-DEBUG: found duplicate: Red Hat Guest
network-cc-panel-DEBUG: found duplicate: Red Hat Guest
network-cc-panel-DEBUG: found duplicate: Red Hat
network-cc-panel-DEBUG: removing Red Hat
network-cc-panel-DEBUG: adding Red Hat
network-cc-panel-DEBUG: found duplicate: Red Hat
network-cc-panel-DEBUG: found duplicate: Red Hat Guest
network-cc-panel-DEBUG: found duplicate: Red Hat
network-cc-panel-DEBUG: found duplicate: Red Hat
network-cc-panel-DEBUG: got /sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/net/wlan0
network-cc-panel-DEBUG: got proxy
network-cc-panel-DEBUG: device /sys/devices/pci0000:00/0000:00:19.0/net/em1 type 1
network-cc-panel-DEBUG: Active connections changed:
network-cc-panel-DEBUG:     /org/freedesktop/NetworkManager/ActiveConnection/1
network-cc-panel-DEBUG:            /sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/net/wlan0
network-cc-panel-DEBUG:            VPN base connection: /org/freedesktop/NetworkManager/ActiveConnection/0
network-cc-panel-DEBUG:     /org/freedesktop/NetworkManager/ActiveConnection/0
network-cc-panel-DEBUG:            /sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/net/wlan0
network-cc-panel-DEBUG: add vpn/NMRemoteConnection remote connection: /org/freedesktop/NetworkManager/Settings/17
network-cc-panel-DEBUG: got /sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/net/wlan0
network-cc-panel-DEBUG: got /sys/devices/pci0000:00/0000:00:19.0/net/em1
network-cc-panel-DEBUG: got proxy
network-cc-panel-DEBUG: 0x2515620 has 18 remote connections
network-cc-panel-DEBUG: add vpn/NMRemoteConnection remote connection: /org/freedesktop/NetworkManager/Settings/17
network-cc-panel-DEBUG: got /sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/net/wlan0
network-cc-panel-DEBUG: got /sys/devices/pci0000:00/0000:00:19.0/net/em1
network-cc-panel-DEBUG: got /org/freedesktop/NetworkManager/Settings/17
network-cc-panel-DEBUG: got saved PUBLIC INTERNET 2.4GHZ
network-cc-panel-DEBUG: got saved Cisco09856
network-cc-panel-DEBUG: got saved mobilcom-debitel Free WLAN
network-cc-panel-DEBUG: got saved necdl
network-cc-panel-DEBUG: got saved Acton Toyota1
network-cc-panel-DEBUG: got saved public
network-cc-panel-DEBUG: got saved AndroidAP7560
network-cc-panel-DEBUG: got saved CTU
network-cc-panel-DEBUG: got saved RUJJS
network-cc-panel-DEBUG: got saved HPW Guest WiFi
network-cc-panel-DEBUG: got saved clasen_home
network-cc-panel-DEBUG: got saved Chelmsford Forum
network-cc-panel-DEBUG: got saved ActonJazzCafe
network-cc-panel-DEBUG: got saved MoonRouter
network-cc-panel-DEBUG: got saved Red Hat Guest


So at least, it parses the operation correctly, but then...

Unfortunately, I have to run out of the office now, not sure if I can continue debugging this without an enterprise wpa ap at home.

Created attachment 224949 [details] [review]
make enterprise wpa work again

Here is a patch.

It is not really tested all the way, since I don't have an enterprise wpa capable access point at home. But it does get to the point where cc_network_panel_connect_to_8021x_network is called when given the right arguments on the commandline.

Would be great if somebody else could test this with an actual network.

Oh, and we should check that the other special arguments still work, too:

create-wifi
connect-hidden-wifi
connect-8021x-wifi
connect-3g
show-device

Patch works, though I get this warning in libnm-gtk:

+ Trace 230884

Better backtrace from libnm-gtk-0.9.7.0-3.git20120820.fc18.x86_64

+ Trace 230885

(In reply to comment #11)
> Created an attachment (id=224949) [details] [review]
> make enterprise wpa work again
> 
> Here is a patch.
> 
> It is not really tested all the way, since I don't have an enterprise wpa
> capable access point at home. But it does get to the point where
> cc_network_panel_connect_to_8021x_network is called when given the right
> arguments on the commandline.
> 
> Would be great if somebody else could test this with an actual network.

We do have nm_device_wifi_get_access_point_by_path() you know :)  A lot simpler than hand-rolling that yourself.

(In reply to comment #15)

> We do have nm_device_wifi_get_access_point_by_path() you know :)  A lot simpler
> than hand-rolling that yourself.

Good to know, thanks.

Created attachment 224959 [details] [review]
use better nm api

Review of attachment 224959 [details] [review]:

Looks good. Do you want to file separate bugs for the other args we need to check?

Got approval from Javier, so pushed